fix(t8s-cluster): only toYaml if field exists#1227
Merged
Conversation
cwrau
requested review from
marvinWolff,
tasches and
teutonet-bot
as code owners
cwrau
force-pushed
the
fix/t8s-cluster/empty-monitoring-labels
branch
from
2e1bb7b to
5f4aaa9
Compare
cwrau
changed the title
toYaml if field existstoYaml if field exists
Contributor
🤖 I have diffed this beep boop"/$namespace/$kind/$name.yaml" for normal resources
|
tasches
approved these changes
Nov 13, 2024
marvinWolff
approved these changes
Nov 18, 2024
otherwise `{}` will be inserted, breaking everything
cwrau
force-pushed
the
fix/t8s-cluster/empty-monitoring-labels
branch
from
5f4aaa9 to
5e7c467
Compare
teutonet-bot
added a commit
that referenced
this pull request
Nov 20, 2024
🤖 I have created a release *beep* *boop* --- ## [9.0.0](t8s-cluster-v8.3.2...t8s-cluster-v9.0.0) (2024-11-18) ### ⚠ BREAKING CHANGES * **t8s-cluster/management-cluster:** update CAPIO and migrate config ([#1197](#1197)) ### Features * **t8s-cluster/cilium:** enable egressGateway ([#1223](#1223)) ([76fb7b0](76fb7b0)) ### Bug Fixes * **base-cluster:** add missing ciliumNetworkPolicy for cinder-csi-plugin otherwise it can't talk to the openstack api 🤣 ([#1114](#1114)) ([f33e5ad](f33e5ad)) * **t8s-cluster/workload-cluster:** this field is _actually_ used 🙄 ([#1174](#1174)) ([16a5b12](16a5b12)) * **t8s-cluster:** create separate etcd defrag jobs per cluster ([#1201](#1201)) ([948868e](948868e)) * **t8s-cluster:** only `toYaml` if field exists ([#1227](#1227)) ([a98420d](a98420d)) * **t8s-cluster:** remove unnecessary require for openstackImageNamePrefix ([#1229](#1229)) ([b9b2154](b9b2154)) * **t8s-cluster:** up etcd-defrag timeout ([#1178](#1178)) ([292b156](292b156)) ### Miscellaneous Chores * **t8s-cluster/dependencies:** update docker.io/bitnami/kubectl docker tag to v1.29.8 ([#1137](#1137)) ([b343ce2](b343ce2)) * **t8s-cluster/dependencies:** update docker.io/bitnami/kubectl docker tag to v1.31.0 ([#908](#908)) ([fa57c6e](fa57c6e)) * **t8s-cluster/dependencies:** update docker.io/bitnami/kubectl docker tag to v1.31.2 ([#1192](#1192)) ([5edddd7](5edddd7)) * **t8s-cluster/dependencies:** update docker.io/bitnami/kubectl:1.29.6 docker digest to 6f94559 ([#1028](#1028)) ([88ea367](88ea367)) * **t8s-cluster/dependencies:** update registry.k8s.io/etcd docker tag to v3.5.15 ([#1078](#1078)) ([bc79a2a](bc79a2a)) * **t8s-cluster/dependencies:** update registry.k8s.io/etcd docker tag to v3.5.16 ([#1211](#1211)) ([969e291](969e291)) * **t8s-cluster/management-cluster:** update CAPIO and migrate config ([#1197](#1197)) ([ff9248b](ff9248b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
SyeKlu
pushed a commit
to SyeKlu/teutonet-helm-charts
that referenced
this pull request
Nov 21, 2024
🤖 I have created a release *beep* *boop* --- ## [9.0.0](teutonet/teutonet-helm-charts@t8s-cluster-v8.3.2...t8s-cluster-v9.0.0) (2024-11-18) ### ⚠ BREAKING CHANGES * **t8s-cluster/management-cluster:** update CAPIO and migrate config ([teutonet#1197](teutonet#1197)) ### Features * **t8s-cluster/cilium:** enable egressGateway ([teutonet#1223](teutonet#1223)) ([76fb7b0](teutonet@76fb7b0)) ### Bug Fixes * **base-cluster:** add missing ciliumNetworkPolicy for cinder-csi-plugin otherwise it can't talk to the openstack api 🤣 ([teutonet#1114](teutonet#1114)) ([f33e5ad](teutonet@f33e5ad)) * **t8s-cluster/workload-cluster:** this field is _actually_ used 🙄 ([teutonet#1174](teutonet#1174)) ([16a5b12](teutonet@16a5b12)) * **t8s-cluster:** create separate etcd defrag jobs per cluster ([teutonet#1201](teutonet#1201)) ([948868e](teutonet@948868e)) * **t8s-cluster:** only `toYaml` if field exists ([teutonet#1227](teutonet#1227)) ([a98420d](teutonet@a98420d)) * **t8s-cluster:** remove unnecessary require for openstackImageNamePrefix ([teutonet#1229](teutonet#1229)) ([b9b2154](teutonet@b9b2154)) * **t8s-cluster:** up etcd-defrag timeout ([teutonet#1178](teutonet#1178)) ([292b156](teutonet@292b156)) ### Miscellaneous Chores * **t8s-cluster/dependencies:** update docker.io/bitnami/kubectl docker tag to v1.29.8 ([teutonet#1137](teutonet#1137)) ([b343ce2](teutonet@b343ce2)) * **t8s-cluster/dependencies:** update docker.io/bitnami/kubectl docker tag to v1.31.0 ([teutonet#908](teutonet#908)) ([fa57c6e](teutonet@fa57c6e)) * **t8s-cluster/dependencies:** update docker.io/bitnami/kubectl docker tag to v1.31.2 ([teutonet#1192](teutonet#1192)) ([5edddd7](teutonet@5edddd7)) * **t8s-cluster/dependencies:** update docker.io/bitnami/kubectl:1.29.6 docker digest to 6f94559 ([teutonet#1028](teutonet#1028)) ([88ea367](teutonet@88ea367)) * **t8s-cluster/dependencies:** update registry.k8s.io/etcd docker tag to v3.5.15 ([teutonet#1078](teutonet#1078)) ([bc79a2a](teutonet@bc79a2a)) * **t8s-cluster/dependencies:** update registry.k8s.io/etcd docker tag to v3.5.16 ([teutonet#1211](teutonet#1211)) ([969e291](teutonet@969e291)) * **t8s-cluster/management-cluster:** update CAPIO and migrate config ([teutonet#1197](teutonet#1197)) ([ff9248b](teutonet@ff9248b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This was referenced Mar 4, 2025
This was referenced May 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
otherwise
{}will be inserted, breaking everything