Adds ModuleConfig.Validate() to allow pre-flight checks on source #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds `ModuleConfig.Validate()` as needed by wapc-go to ensure a module instantiated many times later is checked first. This is a method of config in case we later add the ability to force a format. For now, it relies on detection and the call-site only use binary anyway. Signed-off-by: Adrian Cole <[email protected]>
mathetake
approved these changes
Feb 23, 2022
|
ohh if we are validating we can cache the decode results and improve perf. I will revise one sec! |
Signed-off-by: Adrian Cole <[email protected]>
|
PTAL this isn't the first place I've seen the same wasm used many times for different modules. It may be the case later that we actually pre-compile it and solve #179 |
|
Thanks again for coming out of holiday @mathetake! |
codefromthecrypt
pushed a commit
that referenced
this pull request
Feb 23, 2022
PR #281 allowed repetitive use of the same module config to avoid re-decoding the same wasm. However, it is possible that configuration is renamed in separate goroutines. This makes caching safer by restoring the `WithName` function deleted earlier. By using this, a configuration and its cache state are cloned, and doing that is thread safe. Signed-off-by: Adrian Cole <[email protected]>
codefromthecrypt
added a commit
that referenced
this pull request
Feb 23, 2022
PR #281 allowed repetitive use of the same module config to avoid re-decoding the same wasm. However, it is possible that configuration is renamed in separate goroutines. This makes caching safer by restoring the `WithName` function deleted earlier. By using this, a configuration and its cache state are cloned, and doing that is thread safe. Signed-off-by: Adrian Cole <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
ModuleConfig.Validate()as needed by wapc-go to ensure amodule instantiated many times later is checked first. This is a method
of config in case we later add the ability to force a format. For now,
it relies on detection and the call-site only use binary anyway.