-
Notifications
You must be signed in to change notification settings - Fork 72
fix: sync JS layer types #950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
gianni-cor
merged 10 commits into
tetherto:feature-media-generation
from
donriddo:fix/diffusion-js-layer-fixes
Mar 17, 2026
Merged
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
a199b2e
fix: sync JS layer with C++ addon for lib-infer-diffusion
donriddo c1133c4
fix: complete TypeScript type coverage and relax model load timeout
donriddo e8daa86
fix: remove trailing blank line in addon.js to pass standard lint
donriddo 74715b3
Revert "fix: remove trailing blank line in addon.js to pass standard β¦
donriddo 4d397b4
fix: remove trailing blank line in addon.js
donriddo 90e8f88
fix: restore addonLogging.d.ts default export for SDK compatibility
donriddo 5d415e3
fix: correct config key names to match C++ handler map
donriddo e00d11a
Merge remote-tracking branch 'upstream/feature-media-generation' intoβ¦
donriddo cde6fc3
revert: restore original 120s model load timeout in integration tests
donriddo 286e03d
revert: remove notifyProcessExit wiring from binding.js
donriddo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,2 @@ | ||
| export interface AddonLogging { | ||
| setLogger(callback: (priority: number, message: string) => void): void | ||
| releaseLogger(): void | ||
| } | ||
|
|
||
| declare const addonLogging: AddonLogging | ||
| export default addonLogging | ||
| export function setLogger(callback: (priority: number, message: string) => void): void | ||
| export function releaseLogger(): void | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,6 @@ | ||
| module.exports = require.addon() | ||
| const binding = require.addon() | ||
| const proc = require('bare-process') | ||
|
gianni-cor marked this conversation as resolved.
Outdated
|
||
|
|
||
| if (binding.notifyProcessExit) proc.on('exit', () => binding.notifyProcessExit()) | ||
|
|
||
| module.exports = binding | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.