Skip to content

refactor: Remove redundant formatting in queueOutput calls for cleaner code in WhisperModelJobsHandler #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GustavoA1604 merged 3 commits into from
Feb 11, 2026
Merged

refactor: Remove redundant formatting in queueOutput calls for cleaner code in WhisperModelJobsHandler #258

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9009741
refactor: Remove redundant formatting in queueOutput calls for cleane…
freddy311082 Feb 11, 2026
3954cd4
Merge branch 'main' into fix/whispercpp-cpp-lint
GustavoA1604 Feb 11, 2026
ff66767
Merge branch 'main' into fix/whispercpp-cpp-lint
GustavoA1604 Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
69 changes: 30 additions & 39 deletions packages/qvac-lib-infer-whispercpp/addon/src/addon/WhisperModelJobsHandler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,37 +45,33 @@ void WhisperModelJobsHandler::process(
qvac_lib_inference_addon_cpp::logger::Priority::DEBUG,
"Starting job " + std::to_string(jobId));
status = AddonStatus::Processing;
queueOutput(
Output<typename Model::Output>{
OutputEvent::JobStarted, static_cast<uint32_t>(jobId)});
queueOutput(Output<typename Model::Output>{
OutputEvent::JobStarted, static_cast<uint32_t>(jobId)});

model.setOnSegmentCallback(
[&, jobId](const qvac_lib_inference_addon_whisper::Transcript& tr) {
typename Model::Output output;
output.push_back(tr);
queueOutput(
Output<typename Model::Output>{
OutputEvent::Output,
static_cast<uint32_t>(jobId),
std::move(output)});
queueOutput(Output<typename Model::Output>{
OutputEvent::Output,
static_cast<uint32_t>(jobId),
std::move(output)});
});

try {
model.load();
} catch (const std::exception& e) {
// Note: lk already holds the mutex, don't lock again
queueOutput(
Output<typename Model::Output>{
OutputEvent::Error,
static_cast<uint32_t>(jobId),
typename Output<typename Model::Output>::Error{
std::string(e.what())}});
queueOutput(Output<typename Model::Output>{
OutputEvent::Error,
static_cast<uint32_t>(jobId),
typename Output<typename Model::Output>::Error{
std::string(e.what())}});
// End the job after error so addon doesn't hang
queueOutput(
Output<typename Model::Output>{
OutputEvent::JobEnded,
static_cast<uint32_t>(jobId),
model.runtimeStats()});
queueOutput(Output<typename Model::Output>{
OutputEvent::JobEnded,
static_cast<uint32_t>(jobId),
model.runtimeStats()});
model.reset();
currentJob = nullptr;
continue; // Continue the loop, don't exit
Expand All @@ -96,12 +92,11 @@ void WhisperModelJobsHandler::process(
qvac_lib_inference_addon_cpp::logger::Priority::ERROR,
"Error processing job " + std::to_string(jobId) + ": " +
std::string(e.what()));
queueOutput(
Output<typename Model::Output>{
OutputEvent::Error,
static_cast<uint32_t>(jobId),
typename Output<typename Model::Output>::Error{
std::string(e.what())}});
queueOutput(Output<typename Model::Output>{
OutputEvent::Error,
static_cast<uint32_t>(jobId),
typename Output<typename Model::Output>::Error{
std::string(e.what())}});
}
input.clear();
}
Expand All @@ -111,11 +106,10 @@ void WhisperModelJobsHandler::process(
QLOG(
qvac_lib_inference_addon_cpp::logger::Priority::DEBUG,
"Job " + std::to_string(jobId) + " completed");
queueOutput(
Output<typename Model::Output>{
OutputEvent::JobEnded,
static_cast<uint32_t>(jobId),
model.runtimeStats()});
queueOutput(Output<typename Model::Output>{
OutputEvent::JobEnded,
static_cast<uint32_t>(jobId),
model.runtimeStats()});

model.reset();

Expand Down Expand Up @@ -202,12 +196,10 @@ void WhisperModelJobsHandler::processJob(
qvac_lib_inference_addon_cpp::logger::Priority::ERROR,
"Error in processJob for job " + std::to_string(currentJob->id) + ": " +
std::string(e.what()));
queueOutput(
Output<typename Model::Output>{
OutputEvent::Error,
currentJob->id,
typename Output<typename Model::Output>::Error{
std::string(e.what())}});
queueOutput(Output<typename Model::Output>{
OutputEvent::Error,
currentJob->id,
typename Output<typename Model::Output>::Error{std::string(e.what())}});
}
}

Expand All @@ -218,9 +210,8 @@ void WhisperModelJobsHandler::endJob(
QLOG(
qvac_lib_inference_addon_cpp::logger::Priority::INFO,
"Ending job " + std::to_string(currentJob->id));
queueOutput(
Output<typename Model::Output>{
OutputEvent::JobEnded, currentJob->id, model.runtimeStats()});
queueOutput(Output<typename Model::Output>{
OutputEvent::JobEnded, currentJob->id, model.runtimeStats()});

model.reset();

Expand Down
Loading