-
Notifications
You must be signed in to change notification settings - Fork 94
QVAC-11751 chore: Standardize logger & log levels #257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
opaninakuffo
merged 10 commits into
tetherto:main
from
opaninakuffo:feature/cli-logger-refactor
Feb 11, 2026
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
1e132f8
infra: add GPR scope rewrite action and rename CLI to @qvac/cli
opaninakuffo 969034b
Merge branch 'main' into refactor/cli-gpr-scope-rewrite
opaninakuffo ba5037b
Merge branch 'main' into refactor/cli-gpr-scope-rewrite
opaninakuffo 4d42716
refactor: hardcode workdir in cli-rewrite-sdk-scope action
opaninakuffo e22ad44
refactor: standardize logger & log levels
opaninakuffo 19cdd39
Merge remote-tracking branch 'upstream/main' into feature/cli-logger-…
opaninakuffo e71e962
fix: improve logger validation and console method usage
opaninakuffo 8600136
fix: adjust log levels
opaninakuffo cb47ecf
Merge branch 'main' into feature/cli-logger-refactor
opaninakuffo 9105a32
Merge branch 'main' into feature/cli-logger-refactor
opaninakuffo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,18 +1,39 @@ | ||
| /** | ||
| * Creates a logger with the specified log level. | ||
| * @param {"quiet" | "normal" | "verbose"} logLevel | ||
| */ | ||
| export function createLogger (logLevel) { | ||
| const LOG_LEVELS = { | ||
| silent: 0, | ||
| error: 1, | ||
| warn: 2, | ||
| info: 3, | ||
| debug: 4 | ||
| } | ||
|
|
||
| export function createLogger (level = 'info') { | ||
| if (!(level in LOG_LEVELS)) { | ||
| const validLevels = Object.keys(LOG_LEVELS).join(', ') | ||
| console.warn(`Invalid log level "${level}", falling back to "info". Valid levels: ${validLevels}`) | ||
| } | ||
|
|
||
| const currentLevel = LOG_LEVELS[level] ?? LOG_LEVELS.info | ||
|
|
||
| return { | ||
| log (message, level = 'normal') { | ||
| if (logLevel === 'quiet' && level !== 'quiet') return | ||
| if (level === 'verbose' && logLevel !== 'verbose') return | ||
| console.log(message) | ||
| error (message) { | ||
| if (currentLevel >= LOG_LEVELS.error) { | ||
| console.error(message) | ||
| } | ||
| }, | ||
| verbose (message) { | ||
| if (logLevel === 'verbose') { | ||
| warn (message) { | ||
| if (currentLevel >= LOG_LEVELS.warn) { | ||
| console.warn(message) | ||
| } | ||
| }, | ||
| info (message) { | ||
| if (currentLevel >= LOG_LEVELS.info) { | ||
| console.log(message) | ||
| } | ||
| }, | ||
| debug (message) { | ||
| if (currentLevel >= LOG_LEVELS.debug) { | ||
| console.debug(message) | ||
| } | ||
| } | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.