Skip to content

QVAC-18417 tts-ggml: bump tts-cpp to 2026-06-03 (23 multilingual languages, #19)#2434

Closed
freddy311082 wants to merge 3 commits into
mainfrom
QVAC-18417/tts-ggml-23-multilingual-languages
Closed

QVAC-18417 tts-ggml: bump tts-cpp to 2026-06-03 (23 multilingual languages, #19)#2434
freddy311082 wants to merge 3 commits into
mainfrom
QVAC-18417/tts-ggml-23-multilingual-languages

Conversation

@freddy311082

Copy link
Copy Markdown
Contributor

What

Bumps the tts-cpp dependency to 2026-06-03 (TTS GGML support for all 23
multilingual languages — qvac-ext-lib-whisper.cpp PR #19, merged to master as
c1fd35d8) and moves the vcpkg registry baseline to the qvac-registry-vcpkg
commit that serves that version.

Changes

  • packages/tts-ggml/vcpkg-configuration.json: registry baseline 74d2dfd09eb53a42.
  • packages/tts-ggml/vcpkg.json: tts-cpp version>= 2026-06-02#12026-06-03.

Test plan

  • CI green: tts-ggml resolves and builds tts-cpp@2026-06-03.

@freddy311082 freddy311082 requested review from a team as code owners June 3, 2026 18:08
@freddy311082 freddy311082 added tier1 verified Authorize secrets / label-gate in PR workflows labels Jun 3, 2026

@ogad-tether ogad-tether left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff itself is correct and minimal, but CI is fully red and the PR should not merge as-is — every build/test/lint job fails for a single upstream reason (details below). Leaving as a comment rather than approving.

The diff is valid

  • New registry baseline 9eb53a42 does serve tts-cpp@2026-06-03 (verified in qvac-registry-vcpkg versions DB: 2026-06-03#0), so the baseline move and the version>= bump are internally consistent.

Blocker: the tts-cpp@2026-06-03 registry port has a bad source SHA512

All 9 prebuild jobs (linux/android/ios/darwin/win), cpp-tests-coverage, and cpp-lint fail at the same step — downloading the tts-cpp source archive:

Building tts-cpp[...]@2026-06-03...
Downloading https://github.com/tetherto/qvac-ext-lib-whisper.cpp/archive/c1fd35d8....tar.gz
note: Expected: 5220e542dc15d30c7103f89bd9d38a2a0ae82e82a5338afa381e982b86bc616a...
note: Actual  : 67306c98b58ce83cfa4fd1054f84e263bb601d50b872f9d6ca9e2ebbd7d924ba...
error: building tts-cpp:<triplet> failed with: BUILD_FAILED

The SHA512 recorded in the tts-cpp@2026-06-03 portfile (5220e542…) doesn't match the tarball GitHub actually serves for commit c1fd35d8 (67306c98…). It's deterministic across every runner and platform, so it's not a transient download glitch — the recorded hash is simply wrong for that commit's archive.

This is not fixable in this PR — the source-bump diff is right; the broken port lives in qvac-registry-vcpkg. Next steps:

  1. Fix the tts-cpp@2026-06-03 portfile's SHA512 in qvac-registry-vcpkg (re-record the correct hash for c1fd35d8, after confirming the archive content is the intended merge commit), publish a new registry commit.
  2. Repoint this PR's vcpkg-configuration.json baseline at that new registry commit and re-run CI.
  3. Don't merge until at least the prebuild + cpp-tests matrix is green — the test-plan checkbox ("CI green: resolves and builds tts-cpp@2026-06-03") is currently failing.

(merge-guard / validate-pr is just the verified-label gate — ignore.)

@github-actions

github-actions Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Tier-based Approval Status

**PR Tier:** TIER1

**Current Status:** ❌ PENDING

**Requirements:**
- 1 Team Member approval ❌ (0/1)
- 1 Team Lead OR Management approval ❌ (0/1)



---
*This comment is automatically updated when reviews change.*

ogad-tether
ogad-tether previously approved these changes Jun 4, 2026
@freddy311082

Copy link
Copy Markdown
Contributor Author

CLosing this PR because these changes have been included in #2347

@github-actions

github-actions Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Mobile integration tests — @qvac/tts-ggml (Android)

Result: passed

metric value
Devices passed 2
Devices failed 0
Test cases total 6
Test cases passed 6
Test cases failed 0
Test cases skipped 0

View workflow run

@github-actions

github-actions Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Mobile integration tests — @qvac/tts-ggml (iOS)

Result: passed

metric value
Devices passed 2
Devices failed 0
Test cases total 6
Test cases passed 6
Test cases failed 0
Test cases skipped 0

View workflow run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tier1 verified Authorize secrets / label-gate in PR workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants