QVAC-19213 transcription-parakeet: OpenCL-only overlay test PR for ex…#2426
Closed
pratiknarola-t wants to merge 2 commits into
Closed
QVAC-19213 transcription-parakeet: OpenCL-only overlay test PR for ex…#2426pratiknarola-t wants to merge 2 commits into
pratiknarola-t wants to merge 2 commits into
Conversation
b3e0e70 to
104853a
Compare
…w-fix heads After addressing review on the source PRs (regex Adreno parse + backend-select log cleanup on whisper.cpp #38; combined-OpenCL description parse + tests on ggml #19), bump the overlay pins to the new heads: - parakeet-cpp: 01a71ec6 -> 1cc29a3b - ggml-speech: 89bbeeaa -> bff2347b SHA512 recomputed from the GitHub archive tarballs. spirv-headers patch unchanged (ggml-vulkan CMakeLists is identical between the two ggml heads).
ogad-tether
reviewed
Jun 4, 2026
ogad-tether
left a comment
Contributor
There was a problem hiding this comment.
Reviewed the overlay-port mechanism and the source change. The approach is sound and well-documented, and it does its job: the mobile integration tests pass on both Android (6/6) and iOS (6/6), so the Adreno OpenCL fix is exercised pre-merge. A few notes below — leaving this as a comment rather than an approval, mainly because cpp-lint is red and this is a deliberately temporary PR.
What looks good
- Overlay ports pin to immutable commits with SHA512 (
vcpkg_from_githubREF + SHA512), not branch heads — good supply-chain hygiene for a pre-merge pin. - Version chain is internally consistent:
ggml-speechoverlay2026-05-27#1satisfiesparakeet-cpp'sversion>= 2026-05-27, andparakeet-cppoverlay2026-05-26#2satisfies the rootvcpkg.json'sversion>= 2026-05-26#2. - The Android dep change (
features: ["opencl"], default-features: false) correctly makes Android OpenCL-only; consistent with the overlay's Android default-feature. - The
!vcpkg-overlay-ports/**/*.cmake.gitignorewhitelist is necessary (the global*.cmakeignore would otherwise drop the newportfile.cmakes) and correctly scoped. - Clear "drop this overlay once PR #19 / #38 merges" comments in both portfiles and the manifests.
Blocking-ish
cpp-lintis failing. The errors are allreadability-identifier-namingviolations inParakeetModel.cpp/.hpp(e.g.ggml_log_buf_mutex,tmp_dir,is_gguf,on_segment). I confirmed these exist verbatim onmain— they are pre-existing and not introduced by this diff (which only removes the__ANDROID__useGPUguard). They surface because touching the file triggers clang-tidy on it. If any form of this is meant to merge, the check needs to go green — either fix/suppress the flagged names or scope-exempt the file. Worth flagging since it'll block other PRs that touch this file too. (merge-guard / validate-pris just theverified-label gate, ignore.)
Minor
- Stale SHAs in the PR description. The body cites
qvac-ext-ggml#19 @89bbeeaaandwhisper.cpp#38 @01a71ec6, but the portfiles actually pinbff2347b…and1cc29a3b…(the portfile comments agree with the pins). Looks like the PR branches advanced after the description was written — suggest updating the body so it's clear which heads were tested. - The
useGPUguard removal lives in addon source, not in an overlay, so it persists after the overlays are dropped. That's the intended end-state (OpenCL stabilized on Android, which is now OpenCL-only), but note it also removes the Mali/Vulkan fallback comment/guard entirely — fine as long as Android stays OpenCL-only. - Couldn't diff the overlay portfiles against the actual registry
ggml-speech/parakeet-cppports (separate registry repo) to confirm "mirrors the registry port" line-by-line — trusting the description there.
Contributor
Tier-based Approval Status |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…t-ggml #19 + whisper #38
Pin the addon's ggml-speech + parakeet-cpp vcpkg ports to the two open fix-PR heads (qvac-ext-ggml#19 @89bbeeaa, qvac-ext-lib-whisper.cpp#38 @01a71ec6) via OpenCL-only overlay ports, so the Adreno OpenCL fix can be exercised before the PRs merge. Android features narrowed to opencl; the Android useGPU=false guard is removed so OpenCL is actually used. Temporary -- drop the overlays and bump version>= once the PRs land. Registry baseline untouched.
What problem does this PR solve?
How does it solve it?
Breaking changes