QVAC-19266 infra: migrate tts-ggml desktop CI to registry-based model download#2290
Merged
freddy311082 merged 8 commits intoJun 2, 2026
Merged
Conversation
Contributor
Author
Contributor
Tier-based Approval Status |
Preview deployments for qvac-docs-staging ⚡️
Commit: Deployment ID: Static site name: |
gianni-cor
approved these changes
May 28, 2026
jpgaribotti
approved these changes
May 29, 2026
Contributor
Author
Contributor
Author
|
/review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 What problem does this PR solve?
tts-ggmlwas installing Python + a heavy venv (Torch, librosa, numba, llvmlite) and converting HF weights to GGUF on every run viascripts/convert-models.sh. Slow (~10–30 min cold), fragile (numba wheels on macOS x64 / Python 3.12), and redundant: the same GGUFs are already published in the QVAC model registry.t.pass('Skipped: ...'), so a failed registry fetch or a misconfigured runner went green instead of failing the suite.📝 How does it solve it?
packages/tts-ggml/scripts/download-tts-ggml-models.jsusing@qvac/registry-clientto pull the six GGUFs (chatterbox-t3-turbo,chatterbox-s3gen,chatterbox-t3-mtl,chatterbox-s3gen-mtl,supertonic,supertonic2) from S3 and rebadge theq4_0filenames on-disk to the historical names the resolver expects.download-models:registryexposes the CLI..github/workflows/integration-test-tts-ggml.yml: removed theSetup Python,Cache TTS GGML venv + GGUFs, andnpm run setup-modelssteps. Replaced with the shared./.github/actions/cache-modelscomposite (gated toqvac-*runners, matching parakeet) + aDownload GGUF models from registrystep that runsnpm run download-models:registryon cache miss.t.pass('Skipped: ... GGUF(s) not available')sites across six integration test files tot.fail(...)so a missing model is now a hard failure with a remediation hint (Run \npm run download-models:registry` or stage models locally.).t.pass('Skipped: reference audio missing')` is left in place — that asset lives in the repo, not the registry.integration-mobile-test-tts-ggml.yml) intentionally untouched: it already downloads at runtime.setup-venv.sh,convert-models.sh,scripts/convert-*-to-gguf.py) and their npm entries are kept for local-dev regeneration; they are simply no longer wired into CI.🧪 How was it tested?
npx standardclean on the new CLI and all six edited test files.ReadLintsclean on every edited file.