test[notask]: add behavioral integration tests for tools_compact#2252
Merged
Conversation
tobi-legan
changed the title
tobi-legan
added
verified
Add 12 new integration tests to tools-compact.test.js covering functional tool-call behavior, session resilience, and edge cases that were not previously tested. New coverage: - tool_call output verification - correct tool referenced after swap - conversation history preserved after swap - extended 5-turn session with mixed tool changes - many tools with complex schemas - session save/reload lifecycle - cancel mid-generation resilience - large tool payload near context limit - evolved schema between turns - concurrent model.run() rejection - corrupted session file resilience - enum-typed parameters (mirrors SDK gap) All 19 tests pass locally (89/89 assertions). Co-authored-by: Cursor <cursoragent@cursor.com>
tobi-legan
force-pushed
the
test/dynamic-tools-coverage
branch
from
8935a27 to
0a5ceca
Compare
Contributor
Mobile integration tests — @qvac/llm-llamacpp (iOS)Result: passed
|
Contributor
Mobile integration tests — @qvac/llm-llamacpp (Android)Result: passed
|
iancris
approved these changes
May 26, 2026
Contributor
Tier-based Approval Status |
olyasir
approved these changes
May 26, 2026
Preview deployments for qvac-docs-staging ⚡️
Commit: Deployment ID: Static site name: |
Contributor
Author
|
/review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
tools_compactfeature had no integration tests covering tool_call output verification, concurrent run resilience, session lifecycle, evolved schemas, or enum-typed parametersHow does it solve it?
Adds 12 new integration tests to
tools-compact.test.js(7 existing + 12 new = 19 total), covering behavioral scenarios that were previously untested.New tests:
How was it tested?
All 19 tests pass locally with fresh 0.21.0 native build:
Tested on Apple M4 Pro with Qwen3-0.6B-Q8_0.gguf model,
tools_compact: 'true'.