Enable generic backend init for ESRGAN upscaler#2245
Merged
Conversation
…generic-backend # Conflicts: # packages/diffusion-cpp/addon/src/handlers/SdCtxHandlers.hpp # packages/diffusion-cpp/addon/src/utils/LoggingMacros.hpp
…generic-backend # Conflicts: # packages/diffusion-cpp/addon.js
Avoid constructing log strings from null GGML device names or descriptions while keeping the C++ files clang-format clean. Co-authored-by: Cursor <cursoragent@cursor.com>
gianni-cor
previously approved these changes
May 25, 2026
Contributor
|
/review |
gianni-cor
approved these changes
May 25, 2026
maxim-smotrov
approved these changes
May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recreated after repository history rewrite.
Original PR: #2033
Summary
Notes
The old PR #2033 could not be reopened after the repository history rewrite.
The mandatory upstream flow has also been started:
tetherto/qvac-ext-stable-diffusion.cpp#6
After the sd.cpp PR is merged, the follow-up is: