Skip to content

infra[notask]: use setup-vcpkg action in cpp test workflows#2220

Merged
tamer-hassan-tether merged 1 commit into
mainfrom
tmp-standardize-setup-vcpkg-windows
May 23, 2026
Merged

infra[notask]: use setup-vcpkg action in cpp test workflows#2220
tamer-hassan-tether merged 1 commit into
mainfrom
tmp-standardize-setup-vcpkg-windows

Conversation

@tamer-hassan-tether

Copy link
Copy Markdown
Contributor

Summary

  • Replace duplicated per-OS vcpkg clone/bootstrap steps in cpp test workflows with the shared setup-vcpkg composite action
  • Unify vcpkg cache directory creation across platforms using bash mkdir -p
  • Remove the obsolete Windows VCPKG_INSTALLATION_ROOT override from reusable-prebuilds.yml

Test plan

  • Trigger cpp test workflows (llm, embed, diffusion, vla) on Linux, macOS, and Windows and confirm vcpkg setup succeeds
  • Confirm reusable prebuilds still bootstrap vcpkg correctly on Windows

Replace duplicated per-OS vcpkg clone/bootstrap steps with the shared
setup-vcpkg action and drop the obsolete Windows user-profile override
from reusable-prebuilds.
@tamer-hassan-tether tamer-hassan-tether requested review from a team as code owners May 23, 2026 07:47
@github-actions

github-actions Bot commented May 23, 2026

Copy link
Copy Markdown
Contributor

Tier-based Approval Status

**PR Tier:** TIER1

**Current Status:** ✅ APPROVED

**Requirements:**
- 1 Team Member approval ❌ (0/1)
- 1 Team Lead OR Management approval ✅ (2/1)

**Bypass rule:** Triggered (2+ Team Lead approvals (Tier 1 exception)). This PR is approved regardless of tier.

---
*This comment is automatically updated when reviews change.*

@tamer-hassan-tether tamer-hassan-tether merged commit bbbbc2b into main May 23, 2026
86 of 91 checks passed
@tamer-hassan-tether tamer-hassan-tether deleted the tmp-standardize-setup-vcpkg-windows branch May 23, 2026 08:27
Proletter pushed a commit that referenced this pull request May 24, 2026
Replace duplicated per-OS vcpkg clone/bootstrap steps with the shared setup-vcpkg action and drop the obsolete Windows user-profile override from reusable-prebuilds.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants