infra|fix: add prebuild job to on-merge-classification-ggml workflow#2141
Merged
DmitryMalishev merged 3 commits intoMay 20, 2026
Merged
Conversation
The release pipeline was missing the native-prebuild build step. Without
it, integration tests across all 5 platforms could not load
`libqvac__classification-ggml.{so,dylib,dll}` (ADDON_NOT_FOUND), and the
npm publish step would have shipped a tarball with no `prebuilds/`
directory.
This mirrors the working `on-merge-vla.yml` pattern (and matches what
`on-pr-classification-ggml.yml` already does for PR validation):
* Add a `prebuild` job that reuses
`.github/workflows/prebuilds-classification-ggml.yml`.
* Make `run-integration-tests`, `mobile-integration-tests`,
`publish-gpr`, and `publish-release-npm` depend on `prebuild`.
* Gate `publish-gpr` and `publish-release-npm` on
`needs.prebuild.result == 'success'` so a prebuild failure does not
cascade into a broken npm publish.
* Have `publish-gpr` and `publish-release-npm` download the merged
`prebuilds` artifact produced by `reusable-prebuilds.yml` before
invoking the publish action.
Repro of the original failure:
https://github.com/tetherto/qvac/actions/runs/26159115931 -- all five
`run-integration-tests` matrix legs and both mobile legs fail with
`ADDON_NOT_FOUND`; `publish-release-npm` then also fails (separately --
new package needs npm-scope grant; tracked outside this PR).
Contributor
Author
|
/review |
Contributor
Tier-based Approval Status |
olyasir
approved these changes
May 20, 2026
iancris
approved these changes
May 20, 2026
Contributor
Author
|
/review |
Proletter
pushed a commit
that referenced
this pull request
May 24, 2026
The release pipeline was missing the native-prebuild build step. Without
it, integration tests across all 5 platforms could not load
`libqvac__classification-ggml.{so,dylib,dll}` (ADDON_NOT_FOUND), and the
npm publish step would have shipped a tarball with no `prebuilds/`
directory.
This mirrors the working `on-merge-vla.yml` pattern (and matches what
`on-pr-classification-ggml.yml` already does for PR validation):
* Add a `prebuild` job that reuses
`.github/workflows/prebuilds-classification-ggml.yml`.
* Make `run-integration-tests`, `mobile-integration-tests`,
`publish-gpr`, and `publish-release-npm` depend on `prebuild`.
* Gate `publish-gpr` and `publish-release-npm` on
`needs.prebuild.result == 'success'` so a prebuild failure does not
cascade into a broken npm publish.
* Have `publish-gpr` and `publish-release-npm` download the merged
`prebuilds` artifact produced by `reusable-prebuilds.yml` before
invoking the publish action.
Repro of the original failure:
https://github.com/tetherto/qvac/actions/runs/26159115931 -- all five
`run-integration-tests` matrix legs and both mobile legs fail with
`ADDON_NOT_FOUND`; `publish-release-npm` then also fails (separately --
new package needs npm-scope grant; tracked outside this PR).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix is needed to make NPM releases automatically for Classification Addon
The release pipeline was missing the native-prebuild build step. Without it, integration tests across all 5 platforms could not load
libqvac__classification-ggml.{so,dylib,dll}(ADDON_NOT_FOUND), and the npm publish step would have shipped a tarball with noprebuilds/directory.This mirrors the working
on-merge-vla.ymlpattern (and matches whaton-pr-classification-ggml.ymlalready does for PR validation):prebuildjob that reuses.github/workflows/prebuilds-classification-ggml.yml.run-integration-tests,mobile-integration-tests,publish-gpr, andpublish-release-npmdepend onprebuild.publish-gprandpublish-release-npmonneeds.prebuild.result == 'success'so a prebuild failure does not cascade into a broken npm publish.publish-gprandpublish-release-npmdownload the mergedprebuildsartifact produced byreusable-prebuilds.ymlbefore invoking the publish action.Repro of the original failure:
https://github.com/tetherto/qvac/actions/runs/26159115931 -- all five
run-integration-testsmatrix legs and both mobile legs fail withADDON_NOT_FOUND;publish-release-npmthen also fails (separately -- new package needs npm-scope grant; tracked outside this PR).What problem does this PR solve?
How does it solve it?
Breaking changes