Skip to content

QVAC-18453 chore: remove unused @qvac/response dep from ocr-onnx#2110

Merged
RamazTs merged 6 commits into
tetherto:mainfrom
RamazTs:QVAC-18453-ocr-remove-qvac-response
May 20, 2026
Merged

QVAC-18453 chore: remove unused @qvac/response dep from ocr-onnx#2110
RamazTs merged 6 commits into
tetherto:mainfrom
RamazTs:QVAC-18453-ocr-remove-qvac-response

Conversation

@RamazTs

@RamazTs RamazTs commented May 19, 2026

Copy link
Copy Markdown
Contributor

🎯 What problem does this PR solve?

📝 How does it solve it?

  • Drops "@qvac/response": "^0.1.2" from packages/ocr-onnx/package.json dependencies.
  • Removes the corresponding @qvac/response@0.1.2 line from packages/ocr-onnx/NOTICE.
  • Bumps @qvac/ocr-onnx from 0.5.0 → 0.5.1 and adds a [0.5.1] / Removed entry in CHANGELOG.md.
  • No source changes — verified grep -rn "@qvac/response" packages/ocr-onnx --include=".js" --include=".ts" returns nothing after this change (only the new CHANGELOG.md history entry mentions it).

🧪 How was it tested?

  • Source-tree audit: grep -rn "@qvac/response" packages/ocr-onnx (incl. .js, .ts, .d.ts, .json, CMakeLists.txt, .cmake) — no runtime references; only CHANGELOG.md (history) mentions the package.
  • git diff main...origin/QVAC-18453-ocr-remove-qvac-response --stat → 3 files, +7/-3, scoped entirely to packages/ocr-onnx/.
  • CI on the PR (on-pr-ocr-onnx.yml) will exercise install + unit + integration tests against the slimmed dependency set.

@RamazTs RamazTs requested review from a team as code owners May 19, 2026 05:57
@RamazTs RamazTs added verify tier1 verified Authorize secrets / label-gate in PR workflows labels May 19, 2026
The ocr-onnx addon switched to @qvac/infer-base for QvacResponse and
createJobHandler in 0.4.0 (tetherto#1387), but the direct @qvac/response entry
was left behind in dependencies. No source files reference it.

- Drop @qvac/response from package.json dependencies
- Drop the corresponding NOTICE entry
- Bump version 0.5.0 -> 0.5.1 and add CHANGELOG entry

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@RamazTs

RamazTs commented May 20, 2026

Copy link
Copy Markdown
Contributor Author

/review

@github-actions

github-actions Bot commented May 20, 2026

Copy link
Copy Markdown
Contributor

Tier-based Approval Status

**PR Tier:** TIER1

**Current Status:** ✅ APPROVED

**Requirements:**
- 1 Team Member approval ✅ (1/1)
- 1 Team Lead OR Management approval ✅ (1/1)



---
*This comment is automatically updated when reviews change.*

@RamazTs

RamazTs commented May 20, 2026

Copy link
Copy Markdown
Contributor Author

/review

@github-actions

Copy link
Copy Markdown
Contributor

Mobile integration tests — @qvac/ocr-onnx (iOS)

Result: passed

metric value
Devices passed 4
Devices failed 0
Test cases total 12
Test cases passed 12
Test cases failed 0
Test cases skipped 0

View workflow run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tier1 verified Authorize secrets / label-gate in PR workflows verify

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants