infra[notask]: retire the verify label in favour of verified#2102
Merged
Conversation
The verified label already gates every secret-bearing workflow via label-gate (108 workflows since QVAC-18612). The legacy verify label was still in use on five paths for non-secret heavy CI and a per-package merge assertion, forcing reviewers to apply two labels for the same trust ceremony. Collapse onto verified everywhere. - public-pr.yml merge gate now reads verified. - public-reusable-npm.yml integration step now reads verified. - pr-test-inference-addon-cpp.yml + -js.yml replace their bespoke "verify must be freshly applied" dance with a verified-presence check that still denies on fork synchronize (pending label-gate strip in sibling pull_request_target workflows). Trusted same-repo pushes now re-trigger automatically instead of requiring re-labelling. - pr-test-inference-addon-cpp-verify.yml deleted; its sole purpose was to strip verify on every push, which would actively conflict with label-gate's verified strip policy. - pr-models-validation-registry-server.yml comment refreshed; its authorize-pr invocation picks up the new default. - authorize-pr composite action default flipped from verify to verified. Affects 17 consumers that all already pair authorize-pr with a label-gate job requiring verified, so the change removes the double-label awkwardness for fork PRs without altering the trust model. - Description strings on six on-pr-*.yml workflow_dispatch inputs and two integration-mobile-test comments updated for consistency (run_verify variable kept to avoid breaking dispatch scripts). - docs/ci/LABELS.md collapses the deprecated verify row and expands the verified section to cover the broader scope. - devops-why-my-pr-not SKILL.md C6 row drops the verify-deprecation caveat. Validation: - 58/58 label-gate unit tests pass. - actionlint issue count unchanged (30) across the five edited critical workflows; every remaining warning is pre-existing shellcheck noise in the PowerShell/CMake matrix steps. - yaml.safe_load round-trips every modified workflow. - Grep for remaining verify-label references in .github/ returns only the human-facing run_verify workflow_dispatch input names (kept) and the unrelated qvac verify CLI subcommand bats test. Behavioural changes worth flagging: 1. inference-addon-cpp heavy tests now re-run on every trusted push to a verified PR (previously needed a remove+re-add label dance). Bounded by the existing paths filter. 2. The github label verify itself is NOT deleted by this PR; run gh label delete verify --repo tetherto/qvac after merge so in-flight PRs with the legacy label aren't surprised. Co-authored-by: Cursor <cursoragent@cursor.com>
NamelsKing
previously approved these changes
May 19, 2026
Contributor
Tier-based Approval Status |
Preview deployments for qvac-docs-staging ⚡️
Commit: Deployment ID: Static site name: |
NamelsKing
previously approved these changes
May 20, 2026
tamer-hassan-tether
previously approved these changes
May 20, 2026
darkynt
approved these changes
May 21, 2026
tamer-hassan-tether
approved these changes
May 21, 2026
sidj-ubq
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
verifiedlabel already gates every secret-bearing workflow vialabel-gate(108 workflows since QVAC-18612). The legacyverifylabel was still in use on five paths for non-secret heavy CI and a per-package merge assertion, forcing reviewers to apply two labels for the same trust ceremony.This PR collapses everything onto
verified. No workflow readsverifyafter this lands.What changed
public-pr.ymlnow requiresverifiedfor the per-packagevalidate-prjob (called from 13on-pr-*.yml).public-reusable-npm.ymlintegration-tests step gates onverified.inference-addon-cppverify-fresh-apply logic inpr-test-inference-addon-cpp.yml+-js.ymlreplaced withverified-presence + fork-synchronize deny. The-verify.ymlstrip workflow deleted — it would conflict withlabel-gate'sverifiedstrip policy.pr-models-validation-registry-server.ymlcomment refreshed; itsauthorize-prinvocation picks up the new default..github/actions/authorize-pr/action.ymldefault flippedverify→verified. Affects 17 consumers that all already pairauthorize-prwith alabel-gatejob requiringverified, so the change removes the double-label awkwardness for fork PRs without altering the trust model.docs/ci/LABELS.mdcollapses the deprecated row + expands theverifiedsection..cursor/skills/devops-why-my-pr-not/SKILL.mdC6 drops the verify-deprecation caveat.on-pr-*.ymlworkflow_dispatch input descriptions and 2integration-mobile-test-*.ymlcomments.run_verifyvariable kept to avoid breaking dispatch scripts.Behaviour changes worth flagging
inference-addon-cppre-runs on push — heavy native + JS matrices now re-trigger on every trusted same-repo push to averifiedPR (previously required a remove+re-add ceremony per push). Bounded by the existingpaths:filter so only PRs touchingpackages/inference-addon-cpp/**pay the cost. Fork PRs still need re-labelling on push, mirroringlabel-gate's strip-on-non-trusted-sync policy.verifyGitHub label not deleted — this PR retires every CI consumer, but the label itself stays in the repo so in-flight PRs (feat[api]: add @qvac/ocr-ggml package (EasyOCR + Doctr pipelines, GGML/GGUF) #2050 etc.) aren't surprised. After merge:gh label delete verify --repo tetherto/qvac.Validation
label-gateunit tests pass.actionlintissue count unchanged across the five edited critical workflows (30 pre-existing shellcheck warnings in the PowerShell/CMake matrix — none in any of my edits).yaml.safe_loadround-trips every modified workflow.verifylabel references in.github/returns only the human-facingrun_verifyworkflow_dispatch input names (kept intentionally) and the unrelatedqvac verifyCLI subcommand bats test.Test plan
This PR itself is the integration test — applying
verifiedto it should exercise every gate that this PR touches:verified: anypublic-pr.yml-derivedvalidate-prjobs report the new error string; alllabel-gate-gated jobs skip as expected.verifiedapplied by a trusted reviewer: secret-bearing jobs run;validate-prpasses;authorize-proutputsallowed=true.pr-test-inference-addon-cpp-verify.yml.verifiedas tier 1 (unchanged from PR QVAC-18613 infra: recognise verified label as explicit tier 1 in approval bot #2006).Follow-up
After merge:
gh label delete verify --repo tetherto/qvac(only once in-flight PRs have been resolved).authorize-prcomposite action entirely now thatlabel-gatecovers its single remaining use case, or keep it as a thin shim. Not blocking this PR.Made with Cursor