Skip to content

QVAC-18954: bump qvac-lib-inference-addon-cpp to 1.2.0 across addons#2097

Merged
jpgaribotti merged 7 commits into
tetherto:mainfrom
jpgaribotti:addon-lint
May 19, 2026
Merged

QVAC-18954: bump qvac-lib-inference-addon-cpp to 1.2.0 across addons#2097
jpgaribotti merged 7 commits into
tetherto:mainfrom
jpgaribotti:addon-lint

Conversation

@jpgaribotti

Copy link
Copy Markdown
Contributor

🎯 What problem does this PR solve?

  • The CI linting step currently fails due to code that has drifted while the check was disabled.
  • New stricter string api conventions require a transparent string map to avoid many cases of avoidable temporary std::string materialization.

📝 How does it solve it?

  • Bumps qvac-lib-inference-addon-cpp constraint from 1.1.7#1 to 1.2.0 in addon vcpkg.json files on origin/addon-lint. This version simplifies linting checks to just naming and provides the TransparentStringMap type.
  • Applies the same version floor consistently across:
    • bci-whispercpp, classification-ggml, diffusion-cpp, embed-llamacpp, llm-llamacpp, ocr-onnx, transcription-parakeet, transcription-whispercpp, translation-nmtcpp, tts-ggml, tts-onnx.

🧪 How was it tested?

  • Verified remote branch diff scope with main...origin/addon-lint (single commit, dependency-constraint-only changes).
  • No additional functional/source-code changes included in the remote commit.

Update addon package vcpkg constraints from 1.1.7#1 to 1.2.0 to align on the latest lint-cpp checks and provide access to TransparentStringMap for string api conventions.
@jpgaribotti jpgaribotti requested review from a team as code owners May 18, 2026 09:37
olyasir
olyasir previously approved these changes May 18, 2026
Proletter
Proletter previously approved these changes May 18, 2026
@jpgaribotti

Copy link
Copy Markdown
Contributor Author

/review

@github-actions

Copy link
Copy Markdown
Contributor

Tier-based Approval Status

**PR Tier:** TIER1

**Current Status:** ✅ APPROVED

**Requirements:**
- 1 Team Member approval ❌ (0/1)
- 1 Team Lead OR Management approval ✅ (3/1)

**Bypass rule:** Triggered (2+ Team Lead approvals (Tier 1 exception)). This PR is approved regardless of tier.

---
*This comment is automatically updated when reviews change.*

@jpgaribotti jpgaribotti merged commit a6d9b6a into tetherto:main May 19, 2026
117 of 129 checks passed
@jpgaribotti jpgaribotti deleted the addon-lint branch May 19, 2026 14:32
Proletter pushed a commit that referenced this pull request May 24, 2026
…2097)

* chore: bump qvac-lib-inference-addon-cpp to 1.2.0 across addons

Update addon package vcpkg constraints from 1.1.7#1 to 1.2.0 to align on the latest lint-cpp checks and provide access to TransparentStringMap for string api conventions.

* Added vla to the addon list

---------

Co-authored-by: gianni-cor <gianfranco.cordella@tether.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants