QVAC-17481 infra[notask]: align classification-ggml CI with other addons#2087
Merged
DmitryMalishev merged 2 commits intoMay 15, 2026
Merged
Conversation
…ons (label-gate) + finalize CHANGELOG 0.1.0 Two follow-ups to the classification-ggml addon (PR tetherto#1727): 1) Add the `Authorise (label-gate)` job to `on-pr-classification-ggml.yml`. Every other addon `on-pr-*.yml` workflow (bci-whispercpp, decoder-audio, diffusion-cpp, embed-llamacpp, llm-llamacpp, ocr-onnx, onnx, transcription-parakeet, transcription-whispercpp, translation-nmtcpp, tts-ggml, tts-onnx) runs a `label-gate` job up-front that uses `secrets.PAT_TOKEN` + `.github/actions/label-gate` to authorise secret- bearing downstream jobs. `on-pr-classification-ggml.yml` was the only workflow missing this gate — so on fork PRs that touched `packages/classification-ggml/**` (e.g. PR tetherto#2080 fabric_kleidiai vcpkg port rollout) the addon's full build/lint/test matrix ran without the label gate while every other addon was correctly halted at the gate. This commit wires `label-gate` into the same six secret-bearing jobs gated in `on-pr-embed-llamacpp.yml`: `sanity-checks`, `cpp-lint`, `cpp-tests`, `prebuild`, `run-integration-tests`, `run-mobile-integration-tests`. `ts-checks` and `changes` remain ungated (they don't consume PAT_TOKEN / AWS OIDC), matching the embed-llamacpp pattern exactly. 2) Drop the `— Unreleased` suffix from the `## [0.1.0]` heading in `packages/classification-ggml/CHANGELOG.md`. This matches the `## [0.1.0]` format used by `packages/tts-ggml/CHANGELOG.md` (the most recent first-release analog) and unblocks the `release-merge-guard` action when the `release-classification-ggml-0.1.0` branch is cut to publish `@qvac/classification-ggml@0.1.0` to npm. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
DmitryMalishev
added a commit
that referenced
this pull request
May 15, 2026
Every other addon on-pr-*.yml workflow (classification-ggml, bci-whispercpp, decoder-audio, diffusion-cpp, embed-llamacpp, llm-llamacpp, ocr-onnx, onnx, transcription-parakeet, transcription-whispercpp, translation-nmtcpp, tts-ggml, tts-onnx) runs a `label-gate` job up-front that uses secrets.PAT_TOKEN + .github/actions/label-gate to authorise secret-bearing downstream jobs. on-pr-vla.yml was the only workflow missing this gate, so fork PRs touching packages/vla-ggml/** would have run the addon's full build/lint/test matrix without the label gate while every other addon was correctly halted. Wire label-gate into the same six secret-bearing jobs gated in on-pr-classification-ggml.yml (PR #2087): sanity-checks, cpp-lint, cpp-tests, prebuild, integration-tests, run-mobile-integration-tests. ts-checks, verify-fabric-lockstep, authorize, and merge-guard remain ungated (they do not consume PAT_TOKEN / AWS OIDC). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
Author
|
/review |
Contributor
Tier-based Approval Status |
Victor-Rodzko
approved these changes
May 15, 2026
Contributor
Author
|
/review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Classificaton Addon: (label-gate) + finalize CHANGELOG 0.1.0 for release
Two follow-ups to the classification-ggml addon (PR #1727):
Add the
Authorise (label-gate)job toon-pr-classification-ggml.yml.Every other addon
on-pr-*.ymlworkflow (bci-whispercpp, decoder-audio,diffusion-cpp, embed-llamacpp, llm-llamacpp, ocr-onnx, onnx,
transcription-parakeet, transcription-whispercpp, translation-nmtcpp,
tts-ggml, tts-onnx) runs a
label-gatejob up-front that usessecrets.PAT_TOKEN+.github/actions/label-gateto authorise secret-bearing downstream jobs.
on-pr-classification-ggml.ymlwas the onlyworkflow missing this gate — so on fork PRs that touched
packages/classification-ggml/**(e.g. PR Add vcpkg overlay ports for qvac-fabric with KleidiAI support #2080 fabric_kleidiai vcpkgport rollout) the addon's full build/lint/test matrix ran without the
label gate while every other addon was correctly halted at the gate.
This commit wires
label-gateinto the same six secret-bearing jobsgated in
on-pr-embed-llamacpp.yml:sanity-checks,cpp-lint,cpp-tests,prebuild,run-integration-tests,run-mobile-integration-tests.ts-checksandchangesremainungated (they don't consume PAT_TOKEN / AWS OIDC), matching the
embed-llamacpp pattern exactly.
Drop the
— Unreleasedsuffix from the## [0.1.0]heading inpackages/classification-ggml/CHANGELOG.md. This matches the## [0.1.0]format used bypackages/tts-ggml/CHANGELOG.md(themost recent first-release analog) and unblocks the
release-merge-guardaction when therelease-classification-ggml-0.1.0branch is cut to publish
@qvac/classification-ggml@0.1.0to npm.What problem does this PR solve?
How does it solve it?
Breaking changes