fix: bump @qvac/onnx to ^0.15.0 in transcription-parakeet + release 0.4.0 (followup to #1860)#1982
Closed
ogad-tether wants to merge 2 commits into
Closed
Conversation
@qvac/onnx@0.15.0 (published 2026-05-11 via tetherto#1970) is the first version with the renamed inference-addon-cpp include path. Earlier 0.14.x versions still ship Logger.hpp with #include <qvac-lib-inference-addon-cpp/JsLogger.hpp>, which no longer matches the vcpkg port qvac-lib-inference-addon-cpp@1.1.7#1 (installs under include/inference-addon-cpp/ post QVAC-16441 rename). Without this bump, npm resolves ^0.14.0 to 0.14.0 and parakeet CI fails during the addon build (transcription-parakeet/CMakeLists.txt:93 sets JS_LOGGER via target_compile_definitions): node_modules/@qvac/onnx/prebuilds/include/qvac-onnx/Logger.hpp:32:10: fatal error: 'qvac-lib-inference-addon-cpp/JsLogger.hpp' file not found Followup to QVAC-16441 / tetherto#1860.
This was referenced May 11, 2026
GustavoA1604
previously approved these changes
May 11, 2026
Publishable release containing the @qvac/onnx ^0.15.0 dep bump from the previous commit. Adds CHANGELOG entry under [0.4.0] documenting the include-path follow-up to QVAC-16441 / tetherto#1860. Released as a minor bump (0.3.3 -> 0.4.0) instead of a patch to avoid version-range conflicts with the upcoming SDK 0.10 release line.
2c49bd6 to
d1f019d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@qvac/onnxdep inpackages/transcription-parakeet/package.jsonfrom^0.14.0→^0.15.0transcription-parakeetitself0.3.3→0.4.0(minor, not patch — see below) with a corresponding CHANGELOG entry so the fix gets published@qvac/onnx@0.15.0)Why
@qvac/onnx@0.15.0(published 2026-05-11) is the first version whoseLogger.hppuses the renamed include path#include <inference-addon-cpp/JsLogger.hpp>. Earlier0.14.xversions still reference the old path<qvac-lib-inference-addon-cpp/JsLogger.hpp>.After QVAC-16441 (#1860) renamed
packages/qvac-lib-inference-addon-cpp→packages/inference-addon-cpp, the vcpkg portqvac-lib-inference-addon-cpp@1.1.7#1started installing headers underinclude/inference-addon-cpp/. Without bumping the npm dep,npm installresolves^0.14.0to0.14.0(semver-zero rules), and the addon build fails.transcription-parakeetsetsJS_LOGGERvia packages/transcription-parakeet/CMakeLists.txt:93, so it hits the same include error astts-onnxandocr-onnx:Confirmed reproducer: run 25575833814 —
On Merge Trigger (Parakeet)onmainafter #1860 landed.Why a minor bump (
0.3.3→0.4.0) instead of a patch?Released as a minor bump to avoid version-range conflicts with the upcoming SDK 0.10 release line. A patch (
0.3.4) would still satisfy^0.3.3ranges held by older SDK builds, which we want to avoid pulling the dep bump into.Test plan
On PR Trigger (Parakeet)builds green on this branch (prebuilds + cpp-tests-coverage across all platforms)@qvac/transcription-parakeet@0.4.0publishes successfully and resolves@qvac/onnx@0.15.0🤖 Generated with Claude Code