chore: consolidate PR templates and hide style note in HTML comment#1924
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
|
/review |
Tier-based Approval Status |
❌ E2E Mobile Test Results - iOSOverall Status: FAILED Test Summary
Links
Automated E2E mobile testing powered by AWS Device Farm |
❌ E2E Mobile Test Results - AndroidOverall Status: FAILED Test Summary
Links
Automated E2E mobile testing powered by AWS Device Farm |
❌ E2E Mobile Test Results - iOSOverall Status: FAILED Test Summary
Links
Automated E2E mobile testing powered by AWS Device Farm |
❌ E2E Mobile Test Results - AndroidOverall Status: FAILED Test Summary
Links
Automated E2E mobile testing powered by AWS Device Farm |
❌ E2E Mobile Test Results - iOSOverall Status: FAILED Test Summary
Links
Automated E2E mobile testing powered by AWS Device Farm |
❌ E2E Mobile Test Results - AndroidOverall Status: FAILED Test Summary
Links
Automated E2E mobile testing powered by AWS Device Farm |
What problem does this PR solve?
Two related problems with PR templates in this repo:
.github/PULL_REQUEST_TEMPLATE.md(default) or.github/PULL_REQUEST_TEMPLATE/<name>.md(selectable via?template=). It does not look atpackages/*/PULL_REQUEST_TEMPLATE.md. All 19 per-package files are invisible to GitHub; only the addon PR-creation tooling reads them. 7 were byte-identical to.github/PULL_REQUEST_TEMPLATE/addon.md, 8 more were identical copies of an orphaned generic template that nothing reads, and the remaining 4 (bci-whispercpp,cli,logging,nmtcpp) had incidental drift, not intentional variation.**Note**: be concise and prefer bullet points.line, because that meta-instruction sits as visible Markdown at the top of every template. It was authored as guidance for the PR author at fill-in time but ended up rendered into every PR body and copy-pasted forward by agents.How does it solve it?
Consolidation:
packages/*/PULL_REQUEST_TEMPLATE.mdfiles..github/PULL_REQUEST_TEMPLATE/sdk-pod.mdand.github/PULL_REQUEST_TEMPLATE/addon.md..github/PULL_REQUEST_TEMPLATE.md(What problem / How does it solve it / Breaking changes) so PRs opened via the GitHub UI without?template=get a usable body instead of nothing..cursor/skills/addon-pr-create/SKILL.md— now references.github/PULL_REQUEST_TEMPLATE/addon.md..claude/commands/addons/prepare_pr_description.md— same..github/PULL_REQUEST_TEMPLATE/sdk-pod.md; no change needed there.Style-note cleanup:
**Note**:line in.github/PULL_REQUEST_TEMPLATE/sdk-pod.mdand.github/PULL_REQUEST_TEMPLATE/addon.mdwith an HTML comment containing the same style guidance.Breaking changes
None for end users or CI. For agent tooling: any custom workflow that read a per-package
PULL_REQUEST_TEMPLATE.mddirectly must switch to.github/PULL_REQUEST_TEMPLATE/addon.md(orsdk-pod.md). The two known consumers are updated in this PR.