Skip to content

QVAC-18543 fix: stabilize sdk e2e reports#1920

Merged
lauripiisang merged 4 commits into
mainfrom
fix/sdk-e2e-artifact-comments-runid
May 7, 2026
Merged

QVAC-18543 fix: stabilize sdk e2e reports#1920
lauripiisang merged 4 commits into
mainfrom
fix/sdk-e2e-artifact-comments-runid

Conversation

@lauripiisang

Copy link
Copy Markdown
Contributor

Note: be concise and prefer bullet points.

🎯 What problem does this PR solve?

  • SDK e2e PR comments linked to artifact pages that took reviewers nowhere useful.
  • Mobile test results were tied to Device Farm cleanup timing, delaying useful feedback.
  • SDK e2e run IDs could collide across concurrent runs.
  • Repeated identical failures made PR comments hard to scan.

📝 How does it solve it?

  • Links PR comments directly to meaningful artifacts only: reports and mobile Device Farm logs.
  • Publishes the first result comment when producer results are ready, then refreshes it after mobile logs upload.
  • Generates run IDs from platform, PR number, commit SHA, and GitHub Actions job ID.
  • Collapses repeated identical failures after five occurrences.

🧪 How was it tested?

  • Ran git diff --check.
  • Ran node --check on edited GitHub Script snippets.
  • Verified job ID matching against a real SDK e2e run.
  • Ran actionlint; it still reports existing unrelated workflow issues.

@lauripiisang lauripiisang requested a review from a team as a code owner May 6, 2026 11:58
@github-actions

github-actions Bot commented May 6, 2026

Copy link
Copy Markdown
Contributor

Tier-based Approval Status

**PR Tier:** TIER1

**Current Status:** ✅ APPROVED

**Requirements:**
- 1 Team Member approval ✅ (1/1)
- 1 Team Lead OR Management approval ✅ (1/1)



---
*This comment is automatically updated when reviews change.*

@lauripiisang lauripiisang requested a review from a team as a code owner May 7, 2026 14:49
@lauripiisang lauripiisang requested a review from NamelsKing May 7, 2026 14:52
@lauripiisang

Copy link
Copy Markdown
Contributor Author

/review

@lauripiisang lauripiisang merged commit edef8fa into main May 7, 2026
8 checks passed
@lauripiisang lauripiisang deleted the fix/sdk-e2e-artifact-comments-runid branch May 7, 2026 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants