Skip to content

infra: use collaborator permission API for SDK pod PR checks #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lauripiisang merged 2 commits into from
Feb 10, 2026
Merged

infra: use collaborator permission API for SDK pod PR checks #191

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
578ebc3
fix: check collaborator permissions over api instead
lauripiisang Feb 10, 2026
f7816a6
Merge branch 'main' into infra/fix-sdk-pod-membership-check
lauripiisang Feb 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 27 additions & 3 deletions .github/workflows/pr-checks-sdk-pod.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,15 +33,30 @@ jobs:
# ---------------------------------------------------------------------------
# Strip safe-to-test label on new pushes from external contributors.
# Forces re-review before CI runs on updated code.
# Authors with repo write permission are not stripped (checked in step).
# ---------------------------------------------------------------------------
strip-label:
if: |
github.event.action == 'synchronize' &&
github.event.pull_request.head.repo.full_name != github.repository &&
!contains(fromJSON('["MEMBER","OWNER","COLLABORATOR"]'), github.event.pull_request.author_association)
github.event.pull_request.head.repo.full_name != github.repository
runs-on: ubuntu-latest
steps:
- name: Check author permission
id: perm
env:
GH_TOKEN: ${{ github.token }}
BASE_REPO: ${{ github.repository }}
PR_AUTHOR: ${{ github.event.pull_request.user.login }}
run: |
PERM=$(gh api "repos/$BASE_REPO/collaborators/${PR_AUTHOR}/permission" --jq '.permission' 2>/dev/null || true)
if [[ "$PERM" =~ ^(admin|write|maintain)$ ]]; then
echo "author_has_write=true" >> "$GITHUB_OUTPUT"
else
echo "author_has_write=false" >> "$GITHUB_OUTPUT"
fi

- name: Remove safe-to-test label
if: steps.perm.outputs.author_has_write != 'true'
env:
GH_TOKEN: ${{ github.token }}
PR_NUMBER: ${{ github.event.pull_request.number }}
Expand Down Expand Up @@ -70,6 +85,7 @@ jobs:
EVENT: ${{ github.event_name }}
HEAD_REPO: ${{ github.event.pull_request.head.repo.full_name }}
BASE_REPO: ${{ github.repository }}
PR_AUTHOR: ${{ github.event.pull_request.user.login }}
AUTHOR_ASSOC: ${{ github.event.pull_request.author_association }}
HAS_LABEL: ${{ contains(github.event.pull_request.labels.*.name, 'safe-to-test') }}
run: |
Expand All @@ -85,7 +101,15 @@ jobs:
exit 0
fi

# Org members / collaborators are trusted even from forks
# Collaborator with write (or higher) is trusted even when author_association is not MEMBER/COLLABORATOR
PERM=$(gh api "repos/$BASE_REPO/collaborators/${PR_AUTHOR}/permission" --jq '.permission' 2>/dev/null || true)
if [[ "$PERM" =~ ^(admin|write|maintain)$ ]]; then
echo "::notice::Author has $PERM permission — authorized"
echo "allowed=true" >> "$GITHUB_OUTPUT"
exit 0
fi

# Org members / collaborators (by author_association) are trusted even from forks
if [[ "$AUTHOR_ASSOC" =~ ^(MEMBER|OWNER|COLLABORATOR)$ ]]; then
echo "::notice::Trusted author ($AUTHOR_ASSOC) — authorized"
echo "allowed=true" >> "$GITHUB_OUTPUT"
Expand Down