infra: drop llvm-19 install from setup-build-host#1897
Merged
Conversation
setup-build-host is pinned by SHA at every caller, so changes to its install path only take effect once each caller bumps its `@<sha>` pin. Land this first so the follow-up PR — which switches every C++ workflow to call the dedicated `setup-llvm` composite action (#1894) and bumps the setup-build-host pin in lockstep — can do both moves in one squash-merge without double-installing LLVM (19 here + 22 in setup-llvm) on every prebuild / cpp-lint job in the interim. Callers pinned to the old SHA are unaffected. Callers that bump to this SHA MUST invoke `setup-llvm` themselves on Linux and Windows runners; this action no longer provides a Clang toolchain.
jesusmb1995
approved these changes
May 5, 2026
Contributor
Tier-based Approval Status |
gianni-cor
approved these changes
May 5, 2026
Contributor
|
/review |
tamer-hassan-tether
pushed a commit
that referenced
this pull request
May 5, 2026
setup-build-host is pinned by SHA at every caller, so changes to its install path only take effect once each caller bumps its `@<sha>` pin. Land this first so the follow-up PR — which switches every C++ workflow to call the dedicated `setup-llvm` composite action (#1894) and bumps the setup-build-host pin in lockstep — can do both moves in one squash-merge without double-installing LLVM (19 here + 22 in setup-llvm) on every prebuild / cpp-lint job in the interim. Callers pinned to the old SHA are unaffected. Callers that bump to this SHA MUST invoke `setup-llvm` themselves on Linux and Windows runners; this action no longer provides a Clang toolchain. Co-authored-by: gianni-cor <gianfranco.cordella@tether.io>
Proletter
pushed a commit
that referenced
this pull request
May 24, 2026
setup-build-host is pinned by SHA at every caller, so changes to its install path only take effect once each caller bumps its `@<sha>` pin. Land this first so the follow-up PR — which switches every C++ workflow to call the dedicated `setup-llvm` composite action (#1894) and bumps the setup-build-host pin in lockstep — can do both moves in one squash-merge without double-installing LLVM (19 here + 22 in setup-llvm) on every prebuild / cpp-lint job in the interim. Callers pinned to the old SHA are unaffected. Callers that bump to this SHA MUST invoke `setup-llvm` themselves on Linux and Windows runners; this action no longer provides a Clang toolchain. Co-authored-by: gianni-cor <gianfranco.cordella@tether.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
setup-build-hostis pinned by SHA at every caller (today:reusable-prebuilds.yml,cpp-lint.yaml), so any change to its inlinesudo ./llvm.sh 19 allstep only takes effect once each caller bumps its@<sha>pin.setup-llvmcomposite action (infra: add setup-llvm composite action #1894) and bump itssetup-build-hostSHA pin in lockstep — otherwise the same job ends up double-installing LLVM (19 inline here + 22 fromsetup-llvm) for every prebuild and cpp-lint run until both pins are synced.mainuses squash-merges, the only way to make those two changes land atomically is to publish the LLVM-removedsetup-build-hostas its own merge commit first, so the follow-up PR can pin to it.How does it solve it?
Install llvm-19step from.github/actions/setup-build-host/action.ymlso the action no longer ships any Clang toolchain on its own.descriptionto drop the "install llvm-19" claim and add an explicit callout: callers that need a versioned LLVM toolchain (every C++ workflow today) MUST invokesetup-llvmthemselves on linux/windows runners; that action is the single source of truth for the LLVM major used across the monorepo.Maximize disk spaceon Linux, Windows long-paths / CMake generator / arm64 SDK rename, base X11 dev headers + caller-supplied extras on Linux, Android NDK env + cross toolchain) are unchanged.How was it tested?
setup-build-hostin the repo arereusable-prebuilds.yml(line 170) andcpp-lint.yaml(line 66), and both currently pin tosetup-build-host@1d9b21658…— i.e. they keep installing llvm-19 inline until they bump the pin. So no in-tree consumer is broken by this commit on its own.setup-build-hostSHA pin to this commit and adds an explicittetherto/qvac/.github/actions/setup-llvm@<sha>step to every C++ workflow, where end-to-end CI is exercised against LLVM 22.Breaking Changes
setup-build-hostSHA — they keep installing llvm-19 inline.setup-build-hostno longer provides any Clang/LLVM toolchain on Linux. Those callers MUST invoketetherto/qvac/.github/actions/setup-llvm@<sha>themselves on Linux and Windows runners, otherwisebare-make generate/clang-tidy/clang-format/llvm-covwill not be available on PATH.BEFORE:
AFTER: