Skip to content

QVAC-18190 chore[ci]: update CODEOWNERS and approval check worker for qvac-internal teams#1877

Merged
Proletter merged 2 commits into
mainfrom
QVAC-18190_update_codeowners_and_approval_check_worker
May 4, 2026
Merged

QVAC-18190 chore[ci]: update CODEOWNERS and approval check worker for qvac-internal teams#1877
Proletter merged 2 commits into
mainfrom
QVAC-18190_update_codeowners_and_approval_check_worker

Conversation

@Proletter

@Proletter Proletter commented May 4, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Repoint .github/CODEOWNERS from @tetherto/ai-runtime-merge and @tetherto/ai-runtime-bk to @tetherto/qvac-internal-dev so reviews route to the new QVAC internal team.
  • Update .github/workflows/approval-check-worker.yml to add qvac-internal-merge as a recognized team lead and include it in the team-membership lookup, while keeping the legacy ai-runtime-merge / ai-runtime-merge-mgmt teams in place during the transition.

Changes

File Change
.github/CODEOWNERS * @tetherto/ai-runtime-merge @tetherto/ai-runtime-bk* @tetherto/qvac-internal-dev
.github/workflows/approval-check-worker.yml teamLeads = ["ai-runtime-merge"]["qvac-internal-merge"]; teamsToCheck extended with "qvac-internal-merge" (legacy entries retained)

Test plan

  • CODEOWNERS lint / GitHub UI shows new owner team is resolvable.
  • On a follow-up PR, confirm the approval-check-worker correctly counts approvals from @tetherto/qvac-internal-merge reviewers as team-lead approvals.
  • Confirm legacy ai-runtime-merge* approvals are still counted during the transition window.

… qvac-internal teams

Repoint code ownership from `@tetherto/ai-runtime-merge` and
`@tetherto/ai-runtime-bk` to `@tetherto/qvac-internal-dev`, and add
`qvac-internal-merge` to the approval-check-worker team-lead and
team-member checks while keeping the legacy `ai-runtime-merge*` teams
in place during the transition.

Co-authored-by: Cursor <cursoragent@cursor.com>
@Proletter Proletter requested review from a team as code owners May 4, 2026 09:42
@github-actions

github-actions Bot commented May 4, 2026

Copy link
Copy Markdown
Contributor

Tier-based Approval Status

**PR Tier:** TIER1

**Current Status:** ✅ APPROVED

**Requirements:**
- 1 Team Member approval ❌ (0/1)
- 1 Team Lead OR Management approval ✅ (2/1)

**Bypass rule:** Triggered (2+ Team Lead approvals (Tier 1 exception)). This PR is approved regardless of tier.

---
*This comment is automatically updated when reviews change.*

@Proletter

Copy link
Copy Markdown
Collaborator Author

review

@Proletter Proletter merged commit b58a97f into main May 4, 2026
8 checks passed
@Proletter Proletter deleted the QVAC-18190_update_codeowners_and_approval_check_worker branch May 4, 2026 10:31
tamer-hassan-tether pushed a commit that referenced this pull request May 5, 2026
… qvac-internal teams (#1877)

Repoint code ownership from `@tetherto/ai-runtime-merge` and
`@tetherto/ai-runtime-bk` to `@tetherto/qvac-internal-dev`, and add
`qvac-internal-merge` to the approval-check-worker team-lead and
team-member checks while keeping the legacy `ai-runtime-merge*` teams
in place during the transition.
Proletter added a commit that referenced this pull request May 24, 2026
… qvac-internal teams (#1877)

Repoint code ownership from `@tetherto/ai-runtime-merge` and
`@tetherto/ai-runtime-bk` to `@tetherto/qvac-internal-dev`, and add
`qvac-internal-merge` to the approval-check-worker team-lead and
team-member checks while keeping the legacy `ai-runtime-merge*` teams
in place during the transition.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants