Revert "fix: prevent code injection and untrusted checkout in CI workflows (#1728)"#1871
Merged
Conversation
…flows (#1728)" Reverts commit a79602f, with two intentional exclusions noted below. Excluded from this revert: - .github/actions/run-lint-and-unit-tests/action.yaml: kept at its current state on main; the env-var indirection #1728 introduced for npm-token/pat-token in the .npmrc-configuration step is preserved. - .github/workflows/cpp-lint.yaml: net effect on this file is zero. PR #1829 (commit 65bd746) later rewrote the same `cpp-lint` job and added `id-token: write` to the `permissions` block originally introduced by #1728. The `permissions` block is preserved as-is (contents: read + id-token: write) because #1829's AWS OIDC integration depends on it. All other changes from #1728 are reverted. Co-authored-by: Cursor <cursoragent@cursor.com>
tamer-hassan-tether
had a problem deploying
to
release
GitHub Actions
Failure
tamer-hassan-tether
had a problem deploying
to
release
GitHub Actions
Failure
tamer-hassan-tether
had a problem deploying
to
release
GitHub Actions
Failure
tamer-hassan-tether
had a problem deploying
to
release
GitHub Actions
Failure
tamer-hassan-tether
had a problem deploying
to
release
GitHub Actions
Failure
tamer-hassan-tether
had a problem deploying
to
release
GitHub Actions
Failure
tamer-hassan-tether
had a problem deploying
to
release
GitHub Actions
Failure
tamer-hassan-tether
had a problem deploying
to
release
GitHub Actions
Failure
tamer-hassan-tether
had a problem deploying
to
release
GitHub Actions
Failure
tamer-hassan-tether
had a problem deploying
to
release
GitHub Actions
Failure
tamer-hassan-tether
had a problem deploying
to
release
GitHub Actions
Failure
tamer-hassan-tether
had a problem deploying
to
release
GitHub Actions
Failure
tamer-hassan-tether
had a problem deploying
to
release
GitHub Actions
Failure
tamer-hassan-tether
had a problem deploying
to
release
GitHub Actions
Failure
tamer-hassan-tether
had a problem deploying
to
release
GitHub Actions
Failure
tamer-hassan-tether
had a problem deploying
to
release
GitHub Actions
Failure
tamer-hassan-tether
had a problem deploying
to
release
GitHub Actions
Failure
tamer-hassan-tether
had a problem deploying
to
release
GitHub Actions
Failure
tamer-hassan-tether
had a problem deploying
to
release
GitHub Actions
Failure
tamer-hassan-tether
had a problem deploying
to
release
GitHub Actions
Failure
tamer-hassan-tether
had a problem deploying
to
release
GitHub Actions
Failure
tamer-hassan-tether
had a problem deploying
to
release
GitHub Actions
Failure
tamer-hassan-tether
had a problem deploying
to
release
GitHub Actions
Failure
tamer-hassan-tether
had a problem deploying
to
release
GitHub Actions
Failure
tamer-hassan-tether
had a problem deploying
to
release
GitHub Actions
Failure
tamer-hassan-tether
had a problem deploying
to
release
GitHub Actions
Failure
tamer-hassan-tether
had a problem deploying
to
release
GitHub Actions
Failure
tamer-hassan-tether
had a problem deploying
to
release
GitHub Actions
Failure
tamer-hassan-tether
had a problem deploying
to
release
GitHub Actions
Failure
tamer-hassan-tether
had a problem deploying
to
release
GitHub Actions
Failure
tamer-hassan-tether
had a problem deploying
to
release
GitHub Actions
Failure
tamer-hassan-tether
had a problem deploying
to
release
GitHub Actions
Failure
tamer-hassan-tether
had a problem deploying
to
release
GitHub Actions
Failure
tamer-hassan-tether
had a problem deploying
to
release
GitHub Actions
Failure
tamer-hassan-tether
had a problem deploying
to
release
GitHub Actions
Failure
tamer-hassan-tether
had a problem deploying
to
release
GitHub Actions
Failure
tamer-hassan-tether
had a problem deploying
to
release
GitHub Actions
Failure
tamer-hassan-tether
had a problem deploying
to
release
GitHub Actions
Failure
tamer-hassan-tether
had a problem deploying
to
release
GitHub Actions
Failure
tamer-hassan-tether
had a problem deploying
to
release
GitHub Actions
Failure
tamer-hassan-tether
had a problem deploying
to
release
GitHub Actions
Failure
tamer-hassan-tether
had a problem deploying
to
release
GitHub Actions
Failure
tamer-hassan-tether
had a problem deploying
to
release
GitHub Actions
Failure
tamer-hassan-tether
had a problem deploying
to
release
GitHub Actions
Failure
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
gianni-cor
previously approved these changes
May 2, 2026
Contributor
Tier-based Approval Status |
jpgaribotti
previously approved these changes
May 2, 2026
Contributor
|
/review |
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
gianni-cor
approved these changes
May 2, 2026
jpgaribotti
approved these changes
May 2, 2026
9 tasks
Contributor
❌ E2E Mobile Test Results - iOSOverall Status: FAILED Test Summary
Links
Automated E2E mobile testing powered by AWS Device Farm |
Contributor
❌ E2E Mobile Test Results - AndroidOverall Status: FAILED Test Summary
Links
Automated E2E mobile testing powered by AWS Device Farm |
Contributor
❌ E2E Mobile Test Results - iOSOverall Status: FAILED Test Summary
Links
Automated E2E mobile testing powered by AWS Device Farm |
Contributor
❌ E2E Mobile Test Results - AndroidOverall Status: FAILED Test Summary
Links
Automated E2E mobile testing powered by AWS Device Farm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts commit a79602f, with two intentional exclusions noted below.
Excluded from this revert:
cpp-lintjob and addedid-token: writeto thepermissionsblock originally introduced by fix: prevent code injection and untrusted checkout in CI workflows #1728. Thepermissionsblock is preserved as-is (contents: read + id-token: write) because QVAC-18188: Match cpp-lint to prebuilds #1829's AWS OIDC integration depends on it.All other changes from #1728 are reverted.