Skip to content

test[notask]: fix android sharded-model-resume scudo oom #1831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
opaninakuffo merged 5 commits into from
Apr 30, 2026
Merged

test[notask]: fix android sharded-model-resume scudo oom #1831

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8f24535
test[notask]: fix android sharded-model-resume scudo oom
lauripiisang Apr 30, 2026
08d02c0
Merge branch 'main' into test/sdk-fix-android-sharded-resume
lauripiisang Apr 30, 2026
3f00263
infra[notask]: pass --report-dir to CI sdk producer runs
lauripiisang Apr 30, 2026
6873867
Merge branch 'main' into test/sdk-fix-android-sharded-resume
Victor-Rodzko Apr 30, 2026
67e87cb
Merge branch 'main' into test/sdk-fix-android-sharded-resume
opaninakuffo Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/test-android-sdk.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -576,6 +576,7 @@ jobs:
--runId "${{ needs.build.outputs.runId }}" \
--consumer-timeout "${{ inputs.consumer-timeout }}" \
--config . \
--report-dir=./reports \
$FILTER_ARG \
$SUITE_ARG \
$EXCLUDE_SUITE_ARG
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/test-desktop-sdk.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,6 +370,7 @@ jobs:
'--runId=${{ steps.runid.outputs.runId }}',
'--consumer-timeout=${{ inputs.consumer-timeout }}',
'--config=.',
'--report-dir=./reports',
...filterArgs,
...suiteArgs,
...excludeSuiteArgs
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/test-ios-sdk.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -698,6 +698,7 @@ jobs:
--runId "${{ needs.build.outputs.runId }}" \
--consumer-timeout "${{ inputs.consumer-timeout }}" \
--config . \
--report-dir=./reports \
$FILTER_ARG \
$SUITE_ARG \
$EXCLUDE_SUITE_ARG
Expand Down
12 changes: 7 additions & 5 deletions packages/sdk/tests-qvac/tests/mobile/consumer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,11 +68,13 @@ import { LifecycleExecutor } from "../shared/executors/lifecycle-executor.js";
import { ConfigExecutor } from "../shared/executors/config-executor.js";

const resources = new ResourceManager({
// Mobile (iOS) needs a tick after each unloadModel for the kernel to
// actually release pages — without it, the next test's load arrives
// while the previous model's RSS is still resident and crashes the
// GGML allocator. Empirically 200ms is enough; desktop doesn't need it.
unloadSettleMs: 100,
// Mobile (iOS + Android) needs a tick after each unloadModel for the
// kernel to actually release pages / reclaim mmap regions — without
// it, the next test's load arrives while the previous model's RSS is
// still resident and either the GGML allocator crashes (iOS) or
// Scudo's mmap fails with "internal map failure" (Android). Empirically
// 200ms is enough; desktop doesn't need it.
unloadSettleMs: 200,
});

resources.define("llm", {
Expand Down
10 changes: 5 additions & 5 deletions packages/sdk/tests-qvac/tests/sharded-model-tests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,14 @@ export const shardedModelDetection: TestDefinition = {
params: {},
expectation: { validation: "type", expectedType: "string" },
suites: ["smoke"],
metadata: { category: "sharded-model", dependency: "none", estimatedDurationMs: 120000 },
metadata: { category: "sharded-model", dependency: "sharded-embeddings", estimatedDurationMs: 120000 },
};

export const shardedModelHashValidation: TestDefinition = {
testId: "sharded-model-hash-validation",
params: {},
expectation: { validation: "type", expectedType: "string" },
metadata: { category: "sharded-model", dependency: "none", estimatedDurationMs: 120000 },
metadata: { category: "sharded-model", dependency: "sharded-embeddings", estimatedDurationMs: 120000 },
};

export const shardedModelBackwardCompatibility: TestDefinition = {
Expand All @@ -34,21 +34,21 @@ export const shardedModelProgress: TestDefinition = {
testId: "sharded-model-progress",
params: {},
expectation: { validation: "type", expectedType: "string" },
metadata: { category: "sharded-model", dependency: "none", estimatedDurationMs: 120000 },
metadata: { category: "sharded-model", dependency: "sharded-embeddings", estimatedDurationMs: 120000 },
};

export const shardedModelResume: TestDefinition = {
testId: "sharded-model-resume",
params: {},
expectation: { validation: "type", expectedType: "string" },
metadata: { category: "sharded-model", dependency: "none", estimatedDurationMs: 180000 },
metadata: { category: "sharded-model", dependency: "sharded-embeddings", estimatedDurationMs: 180000 },
};

export const shardedModelCancellation: TestDefinition = {
testId: "sharded-model-cancellation",
params: {},
expectation: { validation: "type", expectedType: "string" },
metadata: { category: "sharded-model", dependency: "none", estimatedDurationMs: 60000 },
metadata: { category: "sharded-model", dependency: "sharded-embeddings", estimatedDurationMs: 60000 },
};

export const shardedModelInference: TestDefinition = {
Expand Down
Loading