QVAC-18096 test[skiplog]: stabilize mobile e2e (skip afriquegemma on ios, raise c…#1773
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
da4187d to
8a65d7a
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
QVAC E2E —
|
Contributor
Contributor
Contributor
Contributor
NamelsKing
previously approved these changes
Apr 30, 2026
Contributor
Tier-based Approval Status |
…hatterbox timeout)
…vert heartbeat to 300s
… stop-sequences flake
lauripiisang
approved these changes
Apr 30, 2026
NamelsKing
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: be concise and prefer bullet points.
🎯 What problem does this PR solve?
📝 How does it solve it?
All mobile — skip diffusion (
packages/sdk/tests-qvac/tests/mobile/consumer.ts):^diffusion-— SD v2.1 1B Q8_0 (~2.16 GB) cold-load reproducibly blocks the JS event loop for 300–600+ s, killing the consumer via heartbeat. iOS Device Farm is variable 5–15 min; Android trips the heartbeat. Replaces the older narrowdiffusion-streaming-progressskip.iOS only — skip OOM-bound models:
^translation-afriquegemma-— AfriqueGemma 4B Q4_K_M (~2.67 GB) SIGSEGVs during load on iPhone 16 Pro Device Farm.Mobile timeout tuning:
tts-chatterbox-short-text: 30 s → 200 sparakeet-ctc-mp3: 120 s → 200 skv-cache-stats-verification: 30 s → 90 sMobile workflow timeouts (
.github/workflows/test-sdk.yml):mobile-consumer-timeoutdefault: 600 s → 1200 sdevice-farm-timeoutdefault: 30 min → 90 minMobile heartbeat — add
--consumer-inactivity-timeoutworkflow input to bothtest-android-sdk.ymlandtest-ios-sdk.yml(default 300 s), making it tunable instead of hardcoded 120 s.Mobile TTS executor bug (
packages/sdk/tests-qvac/tests/mobile/executors/tts-executor.ts):makeSentenceStreambranch.tts-supertonic-sentence-streamwas routed to the regular streaming handler and returned the wrong output format. Ported the method from the desktop executor.TTS executor types (mobile + shared):
as unknown as { ... }casts with sharedTtsParams/TtsResult = ReturnType<typeof textToSpeech>aliases. No behavior change; removes a class of silent contract drift between SDK return shape and tests.Cross-platform — drop test-code flakes:
kv-cache-streaming-sliding-window: replacecontains-any: ["14"]withtype: string. Test contract is "kv cache works with stream:true", not "1B model can do 7+7". Aligns with all sibling kv-cache tests.completion-stop-sequences: replace nondeterministic prompt ("List 10 fruits") with deterministic ("Repeat exactly: apple banana cherry"). Banana is now guaranteed in output; stop-sequence behavior exercised reliably.Addon-busy retry (
packages/sdk/tests-qvac/tests/shared/executors/logging-executor.ts):completion()call inLoggingExecutorwithcallWhenAddonIdle, which absorbs the documentedqvac-lib-infer-llamacpp-llm"a job is already set or being processed" busy throw with a 30 s deadline (then throwsAddonBusyTimeoutErrorwithcause). No SDK-side changes required.🧪 How was it tested?
tts-supertonic-sentence-stream,completion-stop-sequences) are addressed in this PR.npx tsc --noEmitclean inpackages/sdk/tests-qvac.