Skip to content

QVAC-17799 feat[mod]: Regenerate model registry with companion-set metadata#1700

Merged
opaninakuffo merged 4 commits into
tetherto:mainfrom
opaninakuffo:update-model-registry
Apr 23, 2026
Merged

QVAC-17799 feat[mod]: Regenerate model registry with companion-set metadata#1700
opaninakuffo merged 4 commits into
tetherto:mainfrom
opaninakuffo:update-model-registry

Conversation

@opaninakuffo

@opaninakuffo opaninakuffo commented Apr 22, 2026

Copy link
Copy Markdown
Contributor

🎯 What problem does this PR solve?

  • ONNX models with companion data files (e.g. .onnx + _data) had no structured metadata in the registry
  • Bergamot NMT models (model + lex + vocab + metadata) had no structured companion-set metadata in the registry
  • Model constants used outdated MARIAN_OPUS_* naming that no longer matched the upstream registry

📝 How does it solve it?

models.ts regenerated — 34 ONNX models now carry companionSet with setKey, primaryKey, and per-file blob/checksum/size metadata; ~93 Bergamot primary models carry companionSet grouping lex, vocab, and metadata; MARIAN_OPUS_* constants renamed to NMT_*

📦 Models

Added models

NMT_Q0F16 through NMT_Q0F16_9 (10 entries)
NMT_Q4_0 through NMT_Q4_0_12+ (22 entries)

Removed models

MARIAN_OPUS_* (32 entries — renamed to NMT_*)
BERGAMOT_*_LEX (93 entries — now companion-only)
BERGAMOT_*_VOCAB (93 entries — now companion-only)
BERGAMOT_METADATA_* (87 entries — now companion-only)
*_DATA (32 entries — now companion-only, e.g. PARAKEET_TDT_ENCODER_DATA_FP32, TTS_*_DATA)

🧪 How was it tested?

  • Ran bun run update-models twice — second run produced no history diff, confirming idempotency
  • Build and typecheck pass

This PR depends on #1707

Victor-Rodzko
Victor-Rodzko previously approved these changes Apr 22, 2026
@opaninakuffo opaninakuffo marked this pull request as draft April 22, 2026 10:13
@opaninakuffo opaninakuffo changed the title QVAC-13978 feat[mod]: Regenerate model registry with companion-set metadata QVAC-17799 feat[mod]: Regenerate model registry with companion-set metadata Apr 22, 2026
@lauripiisang lauripiisang added the test-e2e-smoke Triggers smoke e2e test suite [Currently SDK-only] label Apr 22, 2026
@lauripiisang lauripiisang removed the test-e2e-smoke Triggers smoke e2e test suite [Currently SDK-only] label Apr 22, 2026
@opaninakuffo opaninakuffo marked this pull request as ready for review April 23, 2026 09:59
@opaninakuffo

Copy link
Copy Markdown
Contributor Author

review

@github-actions

github-actions Bot commented Apr 23, 2026

Copy link
Copy Markdown
Contributor

Tier-based Approval Status

**PR Tier:** TIER1

**Current Status:** ✅ APPROVED

**Requirements:**
- 1 Team Member approval ✅ (2/1)
- 1 Team Lead OR Management approval ✅ (1/1)



---
*This comment is automatically updated when reviews change.*

@opaninakuffo

Copy link
Copy Markdown
Contributor Author

review

@opaninakuffo opaninakuffo merged commit 400534b into tetherto:main Apr 23, 2026
12 of 15 checks passed
Proletter pushed a commit that referenced this pull request May 24, 2026
…tadata (#1700)

* feat[mod]: regenerate model registry with companion-set metadata

* chore: regenerate model registry with companion-set metadata
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants