QVAC-17408: remove ccache from prebuild workflows#1652
Merged
Conversation
Drop ccache install, configure, cache restore/save, stats, and CMAKE_*_LAUNCHER exports from all prebuilds-*.yml workflows. Also drop the -D CMAKE_C_COMPILER_LAUNCHER=ccache / -D CMAKE_CXX_COMPILER_LAUNCHER=ccache flags on `bare-make generate` in prebuilds-qvac-lib-infer-onnx.yml and prebuilds-ocr-onnx.yml. Preserve unrelated Windows bootstrap that shared the ccache step (git config --system core.longpaths true, choco upgrade llvm) and extract the onnx-tts `brew unlink fmt` fmt-header workaround into its own macOS-only step. Non-prebuild workflows (cpp-test-coverage-*, benchmark-*) still use ccache and are out of scope for this change.
97267fb to
0f1e5c1
Compare
gianni-cor
approved these changes
Apr 17, 2026
Contributor
Tier-based Approval Status |
olyasir
approved these changes
Apr 17, 2026
GustavoA1604
approved these changes
Apr 17, 2026
Contributor
Author
|
/review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
hashFiles(vcpkg.json)-keyed combined cache, andgithub.sha-keyed split restore/save), adding maintenance load and review noise.How does it solve it?
prebuilds-*.ymlworkflow instead of standardizing it.Install ccache on Linux/...on macOS/...on Windows,Configure ccache,Get / Restore / Save ccache cache(both combinedactions/cacheand splitactions/cache/restore+actions/cache/save),Show ccache stats, and theCMAKE_C_COMPILER_LAUNCHER/CMAKE_CXX_COMPILER_LAUNCHERexports to$GITHUB_ENV.-D CMAKE_C_COMPILER_LAUNCHER=ccache -D CMAKE_CXX_COMPILER_LAUNCHER=ccacheflags onbare-make generateinprebuilds-qvac-lib-infer-onnx.ymlandprebuilds-ocr-onnx.yml.git config --system core.longpaths true,choco upgrade llvm -y --no-progress) as their own Windows-only step.brew unlink fmt || truefmt header-conflict workaround into its own macOS-only step so it survives the ccache removal.prebuilds-qvac-lib-infer-whispercpp.yml,prebuilds-qvac-lib-infer-parakeet.yml,prebuilds-qvac-lib-infer-onnx-tts.yml,prebuilds-qvac-lib-infer-onnx.yml,prebuilds-ocr-onnx.yml,prebuilds-qvac-lib-infer-llamacpp-llm.yml,prebuilds-qvac-lib-infer-llamacpp-embed.yml,prebuilds-lib-infer-diffusion.yml.cpp-test-coverage-qvac-lib-infer-parakeet.yml,benchmark-qvac-lib-infer-nmtcpp.yml,benchmark-ocr-onnx.yml— these are not prebuild workflows and still use ccache; they can be revisited separately.How was it tested?
ccache,CMAKE_C_COMPILER_LAUNCHER, orCMAKE_CXX_COMPILER_LAUNCHERin anyprebuilds-*.yml.