Skip to content

QVAC-17340: centralize Vulkan SDK setup for prebuild workflows#1630

Merged
jpgaribotti merged 3 commits into
mainfrom
vulkan-sdk-standarization
Apr 17, 2026
Merged

QVAC-17340: centralize Vulkan SDK setup for prebuild workflows#1630
jpgaribotti merged 3 commits into
mainfrom
vulkan-sdk-standarization

Conversation

@jpgaribotti

Copy link
Copy Markdown
Contributor

This PR centralizes the shared Vulkan SDK setup used by several addon prebuild workflows into a single composite GitHub Action.

It reduces duplicated workflow logic while preserving structure.

Changes

  • Add .github/actions/setup-vulkan-sdk/action.yml to handle:
    • Linux Vulkan SDK download and extraction
    • Linux x64 and arm64 VULKAN_SDK setup
    • Linux arm64 S3-backed Vulkan SDK cache restore/upload
    • Linux Vulkan environment exports
    • Windows Vulkan SDK install
  • Update these prebuild workflows to use the shared action instead of inline Vulkan setup steps:
    • prebuilds-qvac-lib-infer-llamacpp-embed.yml
    • prebuilds-qvac-lib-infer-llamacpp-llm.yml
    • prebuilds-qvac-lib-infer-whispercpp.yml
    • prebuilds-lib-infer-diffusion.yml
    • prebuilds-qvac-lib-infer-nmtcpp.yml
  • Keep Android host Vulkan SDK setup enabled in the shared action because the llama.cpp-based Android prebuilds still depend on it.

Test Plan

  • Ran the prebuilds for the addons on the dedicated branch, observed no errors.

@jpgaribotti jpgaribotti self-assigned this Apr 16, 2026
@jpgaribotti jpgaribotti requested review from a team as code owners April 16, 2026 14:35
gianni-cor
gianni-cor previously approved these changes Apr 16, 2026
@github-actions

github-actions Bot commented Apr 16, 2026

Copy link
Copy Markdown
Contributor

Tier-based Approval Status

**PR Tier:** TIER1

**Current Status:** ✅ APPROVED

**Requirements:**
- 1 Team Member approval ❌ (0/1)
- 1 Team Lead OR Management approval ✅ (2/1)

**Bypass rule:** Triggered (2+ Team Lead approvals (Tier 1 exception)). This PR is approved regardless of tier.

---
*This comment is automatically updated when reviews change.*

olyasir
olyasir previously approved these changes Apr 16, 2026
@jpgaribotti jpgaribotti dismissed stale reviews from olyasir and gianni-cor via e4554f5 April 16, 2026 17:11
This pins the vulkan sdk version in a single location so we don't have to hard-code it in a workflow, while still allowing specific prebuilds to override it if needed.
@github-actions

Copy link
Copy Markdown
Contributor

❌ E2E Mobile Test Results - iOS

Overall Status: FAILED
Device Farm Result: UNKNOWN
Platform: iOS
Addon: @qvac/translation-nmtcpp
PR: #1630
Commit: 2365732

Test Summary

Metric Count
Total Tests 0
✅ Passed 0
❌ Failed 0
⏭️ Skipped 0

Links


Automated E2E mobile testing powered by AWS Device Farm
Tests located in: test/mobile/

@github-actions

Copy link
Copy Markdown
Contributor

❌ E2E Mobile Test Results - Android

Overall Status: FAILED
Device Farm Result: UNKNOWN
Platform: Android
Addon: @qvac/translation-nmtcpp
PR: #1630
Commit: 2365732

Test Summary

Metric Count
Total Tests 0
✅ Passed 0
❌ Failed 0
⏭️ Skipped 0

Links


Automated E2E mobile testing powered by AWS Device Farm
Tests located in: test/mobile/

@github-actions

Copy link
Copy Markdown
Contributor

❌ E2E Mobile Test Results - iOS

Overall Status: FAILED
Device Farm Result: UNKNOWN
Platform: iOS
Addon: @qvac/translation-nmtcpp
PR: #1630
Commit: 5a5ea01

Test Summary

Metric Count
Total Tests 0
✅ Passed 0
❌ Failed 0
⏭️ Skipped 0

Links


Automated E2E mobile testing powered by AWS Device Farm
Tests located in: test/mobile/

@github-actions

Copy link
Copy Markdown
Contributor

❌ E2E Mobile Test Results - Android

Overall Status: FAILED
Device Farm Result: UNKNOWN
Platform: Android
Addon: @qvac/translation-nmtcpp
PR: #1630
Commit: 5a5ea01

Test Summary

Metric Count
Total Tests 0
✅ Passed 0
❌ Failed 0
⏭️ Skipped 0

Links


Automated E2E mobile testing powered by AWS Device Farm
Tests located in: test/mobile/

@github-actions

Copy link
Copy Markdown
Contributor

❌ E2E Mobile Test Results - iOS

Overall Status: FAILED
Device Farm Result: UNKNOWN
Platform: iOS
Addon: @qvac/translation-nmtcpp
PR: #1630
Commit: 5a5ea01

Test Summary

Metric Count
Total Tests 0
✅ Passed 0
❌ Failed 0
⏭️ Skipped 0

Links


Automated E2E mobile testing powered by AWS Device Farm
Tests located in: test/mobile/

@github-actions

Copy link
Copy Markdown
Contributor

❌ E2E Mobile Test Results - Android

Overall Status: FAILED
Device Farm Result: UNKNOWN
Platform: Android
Addon: @qvac/translation-nmtcpp
PR: #1630
Commit: 5a5ea01

Test Summary

Metric Count
Total Tests 0
✅ Passed 0
❌ Failed 0
⏭️ Skipped 0

Links


Automated E2E mobile testing powered by AWS Device Farm
Tests located in: test/mobile/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants