QVAC-14576 chore[bc]: remove Opus NMT engine from SDK API surface#1622
Merged
Conversation
Remove Opus engine literal from NMT_ENGINES, opusConfigSchema, MARIAN_LANGUAGES, MarianLanguage type, generateNmtOpusName utility, Opus examples, and Marian Opus test definitions and resources. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
olyasir
previously approved these changes
Apr 16, 2026
Contributor
Tier-based Approval Status |
…ove-opus-sdk-api # Conflicts: # packages/sdk/tests-qvac/tests/translation-marian-tests.ts
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
opaninakuffo
approved these changes
Apr 16, 2026
olyasir
approved these changes
Apr 16, 2026
Proletter
pushed a commit
that referenced
this pull request
May 24, 2026
) * chore: remove Opus NMT engine from SDK API surface Remove Opus engine literal from NMT_ENGINES, opusConfigSchema, MARIAN_LANGUAGES, MarianLanguage type, generateNmtOpusName utility, Opus examples, and Marian Opus test definitions and resources. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * chore: bump @qvac/translation-nmtcpp to ^1.0.1 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Ramaz Tskhadadze <bubu@Ramazs-MacBook-Pro-2.local> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Opus NMT models have been deprecated and removed from the registry. The SDK still exposes Opus-specific schemas, types, naming utilities, examples, and test resources that reference models that no longer exist.
How does it solve it?
Remove all Opus-specific API surface from the SDK:
"Opus"literal fromNMT_ENGINESandopusConfigSchemafrom the discriminated unionMARIAN_LANGUAGESarray andMarianLanguagetypegenerateNmtOpusNamefrom the model naming pipelinetranslation-opus.tsexample and Opus references intranslation-stream.ts,plugins.tsModel registry (
models.ts) is not touched — the SDK team will sync viabun update-modelsbefore release.Breaking changes
BEFORE:
AFTER:
How was it tested?
bun run test:unit— all pass