Skip to content

QVAC-14576 chore[bc]: remove Opus NMT engine from SDK API surface#1622

Merged
NamelsKing merged 3 commits into
mainfrom
feat/QVAC-14576-remove-opus-sdk-api
Apr 16, 2026
Merged

QVAC-14576 chore[bc]: remove Opus NMT engine from SDK API surface#1622
NamelsKing merged 3 commits into
mainfrom
feat/QVAC-14576-remove-opus-sdk-api

Conversation

@RamazTs

@RamazTs RamazTs commented Apr 16, 2026

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Opus NMT models have been deprecated and removed from the registry. The SDK still exposes Opus-specific schemas, types, naming utilities, examples, and test resources that reference models that no longer exist.

How does it solve it?

Remove all Opus-specific API surface from the SDK:

  • "Opus" literal from NMT_ENGINES and opusConfigSchema from the discriminated union
  • MARIAN_LANGUAGES array and MarianLanguage type
  • generateNmtOpusName from the model naming pipeline
  • translation-opus.ts example and Opus references in translation-stream.ts, plugins.ts
  • Marian Opus test definitions, consumer resource configs, and executor references

Model registry (models.ts) is not touched — the SDK team will sync via bun update-models before release.

Breaking changes

BEFORE:

import { MARIAN_OPUS_EN_IT_Q4_0 } from "@qvac/sdk";

const modelId = await loadModel({
  modelSrc: MARIAN_OPUS_EN_IT_Q4_0,
  modelType: "nmt",
  modelConfig: {
    engine: "Opus",
    from: "en",
    to: "it",
  },
});

AFTER:

import { BERGAMOT_EN_ES } from "@qvac/sdk";

const modelId = await loadModel({
  modelSrc: BERGAMOT_EN_ES,
  modelType: "nmt",
  modelConfig: {
    engine: "Bergamot",
    from: "en",
    to: "es",
  },
});

How was it tested?

  • bun run test:unit — all pass
  • Verified no remaining Opus references in schemas, naming, examples, or tests

Cherry-pick to release-sdk-0.9.0 after merge to main.

Remove Opus engine literal from NMT_ENGINES, opusConfigSchema,
MARIAN_LANGUAGES, MarianLanguage type, generateNmtOpusName utility,
Opus examples, and Marian Opus test definitions and resources.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@RamazTs RamazTs requested review from a team as code owners April 16, 2026 09:47
@RamazTs RamazTs changed the title QVAC-14576 chore: remove Opus NMT engine from SDK API surface QVAC-14576 chore[bc]: remove Opus NMT engine from SDK API surface Apr 16, 2026
olyasir
olyasir previously approved these changes Apr 16, 2026
@github-actions

github-actions Bot commented Apr 16, 2026

Copy link
Copy Markdown
Contributor

Tier-based Approval Status

**PR Tier:** TIER1

**Current Status:** ✅ APPROVED

**Requirements:**
- 1 Team Member approval ✅ (1/1)
- 1 Team Lead OR Management approval ✅ (1/1)



---
*This comment is automatically updated when reviews change.*

…ove-opus-sdk-api

# Conflicts:
#	packages/sdk/tests-qvac/tests/translation-marian-tests.ts
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@NamelsKing NamelsKing merged commit 4b1758c into main Apr 16, 2026
23 of 24 checks passed
@NamelsKing NamelsKing deleted the feat/QVAC-14576-remove-opus-sdk-api branch April 16, 2026 11:42
Proletter pushed a commit that referenced this pull request May 24, 2026
)

* chore: remove Opus NMT engine from SDK API surface

Remove Opus engine literal from NMT_ENGINES, opusConfigSchema,
MARIAN_LANGUAGES, MarianLanguage type, generateNmtOpusName utility,
Opus examples, and Marian Opus test definitions and resources.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* chore: bump @qvac/translation-nmtcpp to ^1.0.1

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Ramaz Tskhadadze <bubu@Ramazs-MacBook-Pro-2.local>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants