QVAC-14302 feat[api]: export RuntimeStats interface in NMT addon index.d.ts by RamazTs · Pull Request #1613 · tetherto/qvac

RamazTs · 2026-04-15T18:33:19Z

Summary

Export a new RuntimeStats interface in packages/qvac-lib-infer-nmtcpp/index.d.ts
Fields: totalTokens, totalTime, decodeTime, TPS (required); encodeTime, TTFT (optional — GGML backend only)
Fields match the C++ backend output from addon/src/model-interface/TranslationModel.cpp
Bergamot backend emits: totalTokens, totalTime, decodeTime, TPS
GGML backend emits all of the above plus encodeTime and TTFT

Files changed

packages/qvac-lib-infer-nmtcpp/index.d.ts — added RuntimeStats interface (8 lines)

Test plan

Verify SDK can import RuntimeStats from @qvac/translation-nmtcpp
Confirm no type conflicts with existing interfaces

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Resolve changelog conflict: bump version to 2.0.3 (2.0.2 already taken on main). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

kinsta · 2026-04-15T18:43:43Z

Preview deployments for qvac-docs-staging ⚡️

Status	Branch preview	Commit preview
✅ Ready	Visit preview	Visit preview

Commit: 40095fecc84d555e4368faa4cf7939511d9d8b6a

Deployment ID: 748addf4-f7bb-4a29-9918-2b9542c7ea3c

Static site name: qvac-docs-staging-fazwv

github-actions · 2026-04-15T18:44:33Z

Tier-based Approval Status

**PR Tier:** TIER1

**Current Status:** ✅ APPROVED

**Requirements:**
- 1 Team Member approval ✅ (2/1)
- 1 Team Lead OR Management approval ✅ (1/1)



---
*This comment is automatically updated when reviews change.*

Resolved conflicts in package.json (version bump on top of upstream's 2.1.0) and CHANGELOG.md (added 2.1.1 entry above upstream's 2.1.0 entry).

gianni-cor

Requesting one doc change before merge: please add a JSDoc on RuntimeStats covering the unit asymmetry and which backend emits which fields.

Verified against the C++ producers (TranslationModel.cpp lines 565-617 and nmt_state_backend.cpp lines 273-288):

totalTime, decodeTime, encodeTime → seconds (us / 1e6)
TTFT → milliseconds (C++: encodeTime * 1000.0)
TPS → tokens per second
totalTokens → integer count

The field names give no hint of the seconds-vs-ms split, so without docs a consumer will reasonably assume all *Time fields share units. The sibling qvac-lib-infer-whispercpp already documents this on its own RuntimeStats — same pattern would work nicely here. Inline suggestion attached.

gianni-cor · 2026-05-04T09:28:07Z

Pre-existing nit, not introduced by this PR — but you're already touching adjacent docs:

packages/qvac-lib-infer-nmtcpp/README.md line 371 prints totalTime with the 'ms' label, but the C++ producer emits it in seconds:

console.log('Translation completed in:', response.stats.totalTime, 'ms')

Verified at nmt_state_backend.cpp lines 283-286 (*encode_time = (double)state->t_encode_us / 1e6;) and TranslationModel.cpp line 572 (double totalTime = decodeTime;).

Two options to make this consistent with the new RuntimeStats JSDoc:

console.log('Translation completed in:', response.stats.totalTime, 's')

or

console.log('Translation completed in:', response.stats.totalTime * 1000, 'ms')

Up to you whether to fix here or in a follow-up — flagging since the new typed interface will make this contradiction more visible to SDK users.

Address review on PR #1613: - Add JSDoc to `RuntimeStats` clarifying that `totalTime`/`encodeTime`/ `decodeTime` are seconds while `TTFT` is milliseconds, and listing which fields each backend emits (Bergamot omits `encodeTime`/`TTFT`). Note that pivot translations use prefixed keys. - Fix README quickstart that printed `totalTime` with a `'ms'` label even though the C++ producer emits seconds.

github-actions · 2026-05-04T09:34:46Z

✅ E2E Mobile Test Results - iOS

Overall Status: PASSED
Device Farm Result: PASSED
Platform: iOS
Addon: @qvac/translation-nmtcpp
PR: #1613
Commit: 871eea2

Test Summary

Metric	Count
Total Tests	3
✅ Passed	3
❌ Failed	0
⏭️ Skipped	0

Links

🔗 Device Farm Run: View on AWS Device Farm
🔗 Workflow: View Details
📋 Run ARN: arn:aws:devicefarm:us-west-2:833707431398:run:cef7531e-44ed-4ddf-a349-a4b0f72f680d/d3dca65b-23fb-493c-bebd-d79b5ff2af8e

Automated E2E mobile testing powered by AWS Device Farm
Tests located in: test/mobile/

github-actions · 2026-05-04T09:39:04Z

✅ E2E Mobile Test Results - Android

Overall Status: PASSED
Device Farm Result: PASSED
Platform: Android
Addon: @qvac/translation-nmtcpp
PR: #1613
Commit: 871eea2

Test Summary

Metric	Count
Total Tests	6
✅ Passed	6
❌ Failed	0
⏭️ Skipped	0

Links

🔗 Device Farm Run: View on AWS Device Farm
🔗 Workflow: View Details
📋 Run ARN: arn:aws:devicefarm:us-west-2:833707431398:run:cef7531e-44ed-4ddf-a349-a4b0f72f680d/89b8c35d-629f-4b84-b232-5f9be0014257

Automated E2E mobile testing powered by AWS Device Farm
Tests located in: test/mobile/

github-actions · 2026-05-04T09:39:09Z

🧪 C++ Test Coverage Report

Coverage:

📊 Detailed Coverage

Filename                         Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
NmtLazyInitializeBackend.cpp         104                41    60.58%          12                 2    83.33%         156                52    66.67%          62                30    51.61%
NmtLazyInitializeBackend.hpp           2                 0   100.00%           1                 0   100.00%           1                 0   100.00%           0                 0         -
TranslationModel.cpp                 272               146    46.32%          26                 6    76.92%         463               175    62.20%         138                94    31.88%
TranslationModel.hpp                   1                 0   100.00%           1                 0   100.00%           1                 0   100.00%           0                 0         -
nmt.cpp                               72                22    69.44%           9                 1    88.89%         136                28    79.41%          38                12    68.42%
nmt.hpp                               51                 4    92.16%          11                 2    81.82%          53                 4    92.45%          28                 0   100.00%
nmt_beam_search.cpp                  116                25    78.45%          10                 3    70.00%         254                32    87.40%          74                17    77.03%
nmt_graph_decoder.cpp                164                78    52.44%          15                 7    53.33%         541               161    70.24%         112                69    38.39%
nmt_graph_encoder.cpp                 54                13    75.93%           3                 0   100.00%         268                33    87.69%          36                15    58.33%
nmt_loader.cpp                       270                67    75.19%          14                 0   100.00%         776                97    87.50%         138                61    55.80%
nmt_state_backend.cpp                188                36    80.85%          20                 0   100.00%         412                60    85.44%         118                47    60.17%
nmt_tokenization.cpp                  88                21    76.14%           8                 0   100.00%         135                36    73.33%          58                25    56.90%
nmt_utils.cpp                        121                98    19.01%           6                 2    66.67%         182               147    19.23%          74                64    13.51%
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                               1503               551    63.34%         136                23    83.09%        3378               825    75.58%         876               434    50.46%

gianni-cor · 2026-05-04T09:48:44Z

/review

github-actions · 2026-05-15T18:36:02Z

❌ E2E Mobile Test Results - iOS

Overall Status: FAILED
Device Farm Result: UNKNOWN
Platform: iOS
Addon: @qvac/translation-nmtcpp
PR: #1613
Commit: 436e29c

Test Summary

Metric	Count
Total Tests	0
✅ Passed	0
❌ Failed	0
⏭️ Skipped	0

Links

🔗 Device Farm Run: View on AWS Device Farm
🔗 Workflow: View Details
📋 Run ARN: N/A

Automated E2E mobile testing powered by AWS Device Farm
Tests located in: test/mobile/

github-actions · 2026-05-15T18:38:46Z

❌ E2E Mobile Test Results - Android

Overall Status: FAILED
Device Farm Result: UNKNOWN
Platform: Android
Addon: @qvac/translation-nmtcpp
PR: #1613
Commit: 436e29c

Test Summary

Metric	Count
Total Tests	0
✅ Passed	0
❌ Failed	0
⏭️ Skipped	0

Links

🔗 Device Farm Run: View on AWS Device Farm
🔗 Workflow: View Details
📋 Run ARN: N/A

Automated E2E mobile testing powered by AWS Device Farm
Tests located in: test/mobile/

github-actions · 2026-05-15T18:40:39Z

❌ E2E Mobile Test Results - iOS

Overall Status: FAILED
Device Farm Result: UNKNOWN
Platform: iOS
Addon: @qvac/translation-nmtcpp
PR: #1613
Commit: 436e29c

Test Summary

Metric	Count
Total Tests	0
✅ Passed	0
❌ Failed	0
⏭️ Skipped	0

Links

🔗 Device Farm Run: View on AWS Device Farm
🔗 Workflow: View Details
📋 Run ARN: N/A

Automated E2E mobile testing powered by AWS Device Farm
Tests located in: test/mobile/

github-actions · 2026-05-15T18:41:26Z

❌ E2E Mobile Test Results - Android

Overall Status: FAILED
Device Farm Result: UNKNOWN
Platform: Android
Addon: @qvac/translation-nmtcpp
PR: #1613
Commit: 436e29c

Test Summary

Metric	Count
Total Tests	0
✅ Passed	0
❌ Failed	0
⏭️ Skipped	0

Links

🔗 Device Farm Run: View on AWS Device Farm
🔗 Workflow: View Details
📋 Run ARN: N/A

Automated E2E mobile testing powered by AWS Device Farm
Tests located in: test/mobile/

github-actions · 2026-05-15T18:46:14Z

❌ E2E Mobile Test Results - iOS

Overall Status: FAILED
Device Farm Result: UNKNOWN
Platform: iOS
Addon: @qvac/translation-nmtcpp
PR: #1613
Commit: 436e29c

Test Summary

Metric	Count
Total Tests	0
✅ Passed	0
❌ Failed	0
⏭️ Skipped	0

Links

🔗 Device Farm Run: View on AWS Device Farm
🔗 Workflow: View Details
📋 Run ARN: N/A

Automated E2E mobile testing powered by AWS Device Farm
Tests located in: test/mobile/

github-actions · 2026-05-15T18:46:26Z

❌ E2E Mobile Test Results - Android

Overall Status: FAILED
Device Farm Result: UNKNOWN
Platform: Android
Addon: @qvac/translation-nmtcpp
PR: #1613
Commit: 436e29c

Test Summary

Metric	Count
Total Tests	0
✅ Passed	0
❌ Failed	0
⏭️ Skipped	0

Links

🔗 Device Farm Run: View on AWS Device Farm
🔗 Workflow: View Details
📋 Run ARN: N/A

Automated E2E mobile testing powered by AWS Device Farm
Tests located in: test/mobile/

github-actions · 2026-05-16T07:33:35Z

❌ E2E Mobile Test Results - iOS

Overall Status: FAILED
Device Farm Result: UNKNOWN
Platform: iOS
Addon: @qvac/translation-nmtcpp
PR: #1613
Commit: 25f025c

Test Summary

Metric	Count
Total Tests	0
✅ Passed	0
❌ Failed	0
⏭️ Skipped	0

Links

🔗 Device Farm Run: View on AWS Device Farm
🔗 Workflow: View Details
📋 Run ARN: N/A

Automated E2E mobile testing powered by AWS Device Farm
Tests located in: test/mobile/

github-actions · 2026-05-16T07:33:40Z

❌ E2E Mobile Test Results - iOS

Overall Status: FAILED
Device Farm Result: UNKNOWN
Platform: iOS
Addon: @qvac/translation-nmtcpp
PR: #1613
Commit: 25f025c

Test Summary

Metric	Count
Total Tests	0
✅ Passed	0
❌ Failed	0
⏭️ Skipped	0

Links

🔗 Device Farm Run: View on AWS Device Farm
🔗 Workflow: View Details
📋 Run ARN: N/A

Automated E2E mobile testing powered by AWS Device Farm
Tests located in: test/mobile/

github-actions · 2026-05-16T07:34:30Z

❌ E2E Mobile Test Results - Android

Overall Status: FAILED
Device Farm Result: UNKNOWN
Platform: Android
Addon: @qvac/translation-nmtcpp
PR: #1613
Commit: 25f025c

Test Summary

Metric	Count
Total Tests	0
✅ Passed	0
❌ Failed	0
⏭️ Skipped	0

Links

🔗 Device Farm Run: View on AWS Device Farm
🔗 Workflow: View Details
📋 Run ARN: N/A

Automated E2E mobile testing powered by AWS Device Farm
Tests located in: test/mobile/

github-actions · 2026-05-16T07:36:10Z

❌ E2E Mobile Test Results - Android

Overall Status: FAILED
Device Farm Result: UNKNOWN
Platform: Android
Addon: @qvac/translation-nmtcpp
PR: #1613
Commit: 25f025c

Test Summary

Metric	Count
Total Tests	0
✅ Passed	0
❌ Failed	0
⏭️ Skipped	0

Links

🔗 Device Farm Run: View on AWS Device Farm
🔗 Workflow: View Details
📋 Run ARN: N/A

Automated E2E mobile testing powered by AWS Device Farm
Tests located in: test/mobile/

github-actions · 2026-05-16T07:36:12Z

❌ E2E Mobile Test Results - iOS

Overall Status: FAILED
Device Farm Result: UNKNOWN
Platform: iOS
Addon: @qvac/translation-nmtcpp
PR: #1613
Commit: 25f025c

Test Summary

Metric	Count
Total Tests	0
✅ Passed	0
❌ Failed	0
⏭️ Skipped	0

Links

🔗 Device Farm Run: View on AWS Device Farm
🔗 Workflow: View Details
📋 Run ARN: N/A

Automated E2E mobile testing powered by AWS Device Farm
Tests located in: test/mobile/

github-actions · 2026-05-16T07:37:17Z

❌ E2E Mobile Test Results - Android

Overall Status: FAILED
Device Farm Result: UNKNOWN
Platform: Android
Addon: @qvac/translation-nmtcpp
PR: #1613
Commit: 25f025c

Test Summary

Metric	Count
Total Tests	0
✅ Passed	0
❌ Failed	0
⏭️ Skipped	0

Links

🔗 Device Farm Run: View on AWS Device Farm
🔗 Workflow: View Details
📋 Run ARN: N/A

Automated E2E mobile testing powered by AWS Device Farm
Tests located in: test/mobile/

github-actions · 2026-06-03T09:36:25Z

❌ E2E Mobile Test Results - iOS

Overall Status: FAILED
Device Farm Result: UNKNOWN
Platform: iOS
Addon: @qvac/translation-nmtcpp
PR: #1613
Commit: 871eea2

Test Summary

Metric	Count
Total Tests	0
✅ Passed	0
❌ Failed	0
⏭️ Skipped	0

Links

🔗 Device Farm Run: View on AWS Device Farm
🔗 Workflow: View Details
📋 Run ARN: N/A

Automated E2E mobile testing powered by AWS Device Farm
Tests located in: test/mobile/

github-actions · 2026-06-03T09:38:18Z

❌ E2E Mobile Test Results - Android

Overall Status: FAILED
Device Farm Result: UNKNOWN
Platform: Android
Addon: @qvac/translation-nmtcpp
PR: #1613
Commit: 871eea2

Test Summary

Metric	Count
Total Tests	0
✅ Passed	0
❌ Failed	0
⏭️ Skipped	0

Links

🔗 Device Farm Run: View on AWS Device Farm
🔗 Workflow: View Details
📋 Run ARN: N/A

Automated E2E mobile testing powered by AWS Device Farm
Tests located in: test/mobile/

feat[api]: export RuntimeStats interface in NMT addon index.d.ts

1664413

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

RamazTs requested review from a team as code owners April 15, 2026 18:33

RamazTs had a problem deploying to release April 15, 2026 18:35 — with GitHub Actions Failure

chore: bump @qvac/translation-nmtcpp to 2.0.2 and update changelog

e7c87b8

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

RamazTs had a problem deploying to release April 15, 2026 18:40 — with GitHub Actions Failure

Merge upstream/main into feat/QVAC-14302-export-runtimestats-nmt

40095fe

Resolve changelog conflict: bump version to 2.0.3 (2.0.2 already taken on main). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

kinsta Bot deployed to preview April 15, 2026 18:43 View deployment

RamazTs had a problem deploying to release April 16, 2026 07:35 — with GitHub Actions Failure

Alok-Ranjan23 previously approved these changes Apr 16, 2026

View reviewed changes

Merge upstream/main — bump version to 2.1.1

753f6bd

Resolved conflicts in package.json (version bump on top of upstream's 2.1.0) and CHANGELOG.md (added 2.1.1 entry above upstream's 2.1.0 entry).

Alok-Ranjan23 reviewed May 4, 2026

View reviewed changes

Comment thread packages/qvac-lib-infer-nmtcpp/index.d.ts

This comment was marked as duplicate.

Sign in to view

gianni-cor requested changes May 4, 2026

View reviewed changes

Comment thread packages/qvac-lib-infer-nmtcpp/index.d.ts

iancris approved these changes May 4, 2026

View reviewed changes

Alok-Ranjan23 approved these changes May 4, 2026

View reviewed changes

gianni-cor approved these changes May 4, 2026

View reviewed changes

Conversation

RamazTs commented Apr 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Files changed

Test plan

Uh oh!

kinsta Bot commented Apr 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Preview deployments for qvac-docs-staging ⚡️

Uh oh!

github-actions Bot commented Apr 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Tier-based Approval Status

Uh oh!

Uh oh!

This comment was marked as duplicate.

Uh oh!

gianni-cor left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

gianni-cor commented May 4, 2026

Uh oh!

github-actions Bot commented May 4, 2026

✅ E2E Mobile Test Results - iOS

Test Summary

Links

Uh oh!

github-actions Bot commented May 4, 2026

✅ E2E Mobile Test Results - Android

Test Summary

Links

Uh oh!

github-actions Bot commented May 4, 2026

🧪 C++ Test Coverage Report

Uh oh!

gianni-cor commented May 4, 2026

Uh oh!

github-actions Bot commented May 15, 2026

❌ E2E Mobile Test Results - iOS

Test Summary

Links

Uh oh!

github-actions Bot commented May 15, 2026

❌ E2E Mobile Test Results - Android

Test Summary

Links

Uh oh!

github-actions Bot commented May 15, 2026

❌ E2E Mobile Test Results - iOS

Test Summary

Links

Uh oh!

github-actions Bot commented May 15, 2026

❌ E2E Mobile Test Results - Android

Test Summary

Links

Uh oh!

github-actions Bot commented May 15, 2026

❌ E2E Mobile Test Results - iOS

Test Summary

Links

Uh oh!

github-actions Bot commented May 15, 2026

❌ E2E Mobile Test Results - Android

Test Summary

Links

Uh oh!

github-actions Bot commented May 16, 2026

❌ E2E Mobile Test Results - iOS

Test Summary

Links

Uh oh!

github-actions Bot commented May 16, 2026

❌ E2E Mobile Test Results - iOS

Test Summary

Links

Uh oh!

github-actions Bot commented May 16, 2026

RamazTs commented Apr 15, 2026 •

edited

Loading

kinsta Bot commented Apr 15, 2026 •

edited

Loading

github-actions Bot commented Apr 15, 2026 •

edited

Loading