Skip to content

QVAC-11724 feat[api]: implement cancel embed operation#1607

Merged
simon-iribarren merged 1 commit into
tetherto:mainfrom
simon-iribarren:feat/qvac-11724-cancel-embed-operation
Apr 16, 2026
Merged

QVAC-11724 feat[api]: implement cancel embed operation#1607
simon-iribarren merged 1 commit into
tetherto:mainfrom
simon-iribarren:feat/qvac-11724-cancel-embed-operation

Conversation

@simon-iribarren

Copy link
Copy Markdown
Contributor

Note: be concise and prefer bullet points.

🎯 What problem does this PR solve?

  • No way to cancel an in-flight embed() call — users had to wait for the full embedding to complete even if it was no longer needed.

📝 How does it solve it?

  • Adds operation: "embeddings" as a new variant of the cancel() API.
  • Routes through the same bare cancel() path as operation: "inference", calling model.addon.cancel() on the embedding model.
  • Delegation support added for cases where the embedding model is served by a remote peer.

🔌 API Changes

// Cancel an in-flight embed call
void embed({ modelId, text });
await new Promise(resolve => setTimeout(resolve, 1000));
await cancel({ operation: "embeddings", modelId });

@gianni-cor

Copy link
Copy Markdown
Contributor

the addon already has the cancel method. are you using that?

@github-actions

github-actions Bot commented Apr 15, 2026

Copy link
Copy Markdown
Contributor

Tier-based Approval Status

**PR Tier:** TIER1

**Current Status:** ✅ APPROVED

**Requirements:**
- 1 Team Member approval ✅ (1/1)
- 1 Team Lead OR Management approval ✅ (1/1)



---
*This comment is automatically updated when reviews change.*

@simon-iribarren

Copy link
Copy Markdown
Contributor Author

/review

@simon-iribarren simon-iribarren merged commit 975d06d into tetherto:main Apr 16, 2026
25 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants