Skip to content

fix[notask]: destructure embedding from new embed() return shape in sdk-tests #1598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
donriddo wants to merge 1 commit into from
Closed

fix[notask]: destructure embedding from new embed() return shape in sdk-tests #1598

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/sdk/tests-qvac/tests/shared/executors/embedding-executor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export class EmbeddingExecutor extends AbstractModelExecutor<
if (p.texts) {
const embeddings = [];
for (const text of p.texts) {
const embedding = await embed({ modelId: embeddingModelId, text });
const { embedding } = await embed({ modelId: embeddingModelId, text });
embeddings.push(embedding);
}
return ValidationHelpers.validate(
Expand All @@ -34,7 +34,7 @@ export class EmbeddingExecutor extends AbstractModelExecutor<
}

const text = p.text || "";
const embedding = await embed({ modelId: embeddingModelId, text });
const { embedding } = await embed({ modelId: embeddingModelId, text });
return ValidationHelpers.validate(embedding, expectation as Expectation);
} catch (error) {
const errorMsg = error instanceof Error ? error.message : String(error);
Expand Down
2 changes: 1 addition & 1 deletion packages/sdk/tests-qvac/tests/shared/executors/error-executor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ export class ErrorExecutor extends AbstractModelExecutor<typeof errorTests> {
const p = params as { text: string };
const embeddingModelId = await this.resources.ensureLoaded("embeddings");
try {
const result = await embed({ modelId: embeddingModelId, text: p.text });
const { embedding: result } = await embed({ modelId: embeddingModelId, text: p.text });
return ValidationHelpers.validate(result, expectation as Expectation);
} catch (error) {
return { passed: true, output: `SDK correctly rejected empty input: ${error}` };
Expand Down
2 changes: 1 addition & 1 deletion packages/sdk/tests-qvac/tests/shared/executors/http-embedding-executor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ export class HttpEmbeddingExecutor extends AbstractModelExecutor<typeof httpEmbe
modelType: p.modelType as "embeddings",
});
this.resources.register("embeddings", modelId);
const embeddings = await embed({ modelId, text: p.text });
const { embedding: embeddings } = await embed({ modelId, text: p.text });
return ValidationHelpers.validate(embeddings, expectation as Expectation);
} catch (error) {
const errorMsg = error instanceof Error ? error.message : String(error);
Expand Down
4 changes: 2 additions & 2 deletions packages/sdk/tests-qvac/tests/shared/executors/sharded-model-executor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ export class ShardedModelExecutor extends AbstractModelExecutor<typeof shardedMo
const modelId = await this.resources.ensureLoaded("sharded-embeddings");

try {
const embeddings = await embed({ modelId, text: p.text });
const { embedding: embeddings } = await embed({ modelId, text: p.text });
return ValidationHelpers.validate(embeddings, expectation as Expectation);
} catch (error) {
const errorMsg = error instanceof Error ? error.message : String(error);
Expand All @@ -64,7 +64,7 @@ export class ShardedModelExecutor extends AbstractModelExecutor<typeof shardedMo
try {
const embeddings = [];
for (const text of p.texts) {
const embedding = await embed({ modelId, text });
const { embedding } = await embed({ modelId, text });
embeddings.push(embedding);
}
return ValidationHelpers.validate(embeddings, expectation as Expectation);
Expand Down
Loading