Skip to content

Fix failing Cpp tests in TTS package #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GustavoA1604 merged 4 commits into from
Feb 6, 2026
Merged

Fix failing Cpp tests in TTS package #137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ffe13dd
fix: Add value for taskeelModelDir in PiperEngineTest.cpp
Feb 5, 2026
b7f4beb
fix: Add TaskeelDiacritizer.cpp in CMakeLists.txt
Feb 6, 2026
bcf9dab
Merge branch 'main' into fix/tts-cpp-tests
ishanvohra2 Feb 6, 2026
0c4bc5d
Merge branch 'main' into fix/tts-cpp-tests
GustavoA1604 Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/qvac-lib-infer-onnx-tts/addon/test/unit/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ target_sources(
PRIVATE
${CMAKE_SOURCE_DIR}/addon/src/model-interface/PiperEngine.cpp
${CMAKE_SOURCE_DIR}/addon/src/model-interface/TTSModel.cpp
${CMAKE_SOURCE_DIR}/addon/src/model-interface/TashkeelDiacritizer.cpp
${TEST_SOURCES}
${TEST_MOCKS}
)
Expand Down
6 changes: 3 additions & 3 deletions packages/qvac-lib-infer-onnx-tts/addon/test/unit/src/PiperEngineTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,17 +12,17 @@ class PiperEngineTest : public ::testing::Test {
const std::filesystem::path configJsonPath_ = basePath_ / "en_US-amy-low.onnx.json";

TTSConfig validConfig_ {
modelPath_.string(), configJsonPath_.string(), "en", eSpeakDataPath_.string(), false
modelPath_.string(), configJsonPath_.string(), "en", eSpeakDataPath_.string(), "", false
};

TTSConfig emptyConfig_ {};

TTSConfig invalidModelPathConfig_ {
"invalid", configJsonPath_.string(), "en", eSpeakDataPath_.string(), false
"invalid", configJsonPath_.string(), "en", eSpeakDataPath_.string(), "", false
};

TTSConfig invalidConfigJsonPathConfig_ {
modelPath_.string(), "invalid", "en", eSpeakDataPath_.string(), false
modelPath_.string(), "invalid", "en", eSpeakDataPath_.string(), "", false
};

};
Expand Down
Loading