Skip to content

fix[notask]: add sdcpp-generation to CLI BUILTIN_PLUGINS#1338

Merged
donriddo merged 6 commits into
tetherto:mainfrom
donriddo:fix/cli-add-diffusion-builtin-plugin
Apr 6, 2026
Merged

fix[notask]: add sdcpp-generation to CLI BUILTIN_PLUGINS#1338
donriddo merged 6 commits into
tetherto:mainfrom
donriddo:fix/cli-add-diffusion-builtin-plugin

Conversation

@donriddo

@donriddo donriddo commented Apr 3, 2026

Copy link
Copy Markdown
Contributor

Note: be concise and prefer bullet points.

🎯 What problem does this PR solve?

  • Mobile worker bundle generated by qvac bundle sdk is missing sdcpp-generation (diffusion) plugin
  • Causes "Plugin not found for model type sdcpp-generation" on mobile (React Native / Bare Kit)
  • README built-in plugins list was out of date (missing parakeet-transcription and sdcpp-generation)

📝 How does it solve it?

  • Add sdcpp-generation to BUILTIN_PLUGINS in constants.ts
  • Update README to list all 8 built-in plugins
  • Bump version to 0.2.3, update changelog

🧪 How was it tested?

The mobile worker bundle generated by `qvac bundle sdk` was missing the
diffusion plugin (sdcpp-generation). This caused "Plugin not found" errors
when loading diffusion models on mobile (React Native / Bare Kit).

The plugin is already registered in server/worker.ts (desktop Bare) and
pear/pre.ts (Pear desktop). This aligns the CLI's mobile bundle with
those two lists.
@donriddo donriddo requested review from a team as code owners April 3, 2026 09:56
donriddo added a commit that referenced this pull request Apr 3, 2026
- Workflow patches consumer with local @qvac/cli after initial build
- SDK uses file:../lib-infer-diffusion for path fix from #1077
- Both are temporary for testing; proper fixes in PR #1338 and #1314
- Version bump 0.2.2 -> 0.2.3
- Changelog: document sdcpp-generation and parakeet-transcription additions
- README: add parakeet-transcription and sdcpp-generation to built-in plugins list
NamelsKing
NamelsKing previously approved these changes Apr 6, 2026
@NamelsKing NamelsKing dismissed their stale review April 6, 2026 11:38

PR checks

@donriddo donriddo changed the title fix: add sdcpp-generation to CLI BUILTIN_PLUGINS fix[notask]: add sdcpp-generation to CLI BUILTIN_PLUGINS Apr 6, 2026
@donriddo

donriddo commented Apr 6, 2026

Copy link
Copy Markdown
Contributor Author

/review

@github-actions

github-actions Bot commented Apr 6, 2026

Copy link
Copy Markdown
Contributor

Tier-based Approval Status

**PR Tier:** TIER1

**Current Status:** ✅ APPROVED

**Requirements:**
- 1 Team Member approval ✅ (1/1)
- 1 Team Lead OR Management approval ✅ (1/1)



---
*This comment is automatically updated when reviews change.*

@donriddo donriddo merged commit eff07c7 into tetherto:main Apr 6, 2026
7 of 9 checks passed
@donriddo donriddo deleted the fix/cli-add-diffusion-builtin-plugin branch April 6, 2026 12:36
Proletter added a commit that referenced this pull request May 24, 2026
* fix: add sdcpp-generation to CLI BUILTIN_PLUGINS

The mobile worker bundle generated by `qvac bundle sdk` was missing the
diffusion plugin (sdcpp-generation). This caused "Plugin not found" errors
when loading diffusion models on mobile (React Native / Bare Kit).

The plugin is already registered in server/worker.ts (desktop Bare) and
pear/pre.ts (Pear desktop). This aligns the CLI's mobile bundle with
those two lists.

* fix: bump CLI to 0.2.3, update changelog and README

- Version bump 0.2.2 -> 0.2.3
- Changelog: document sdcpp-generation and parakeet-transcription additions
- README: add parakeet-transcription and sdcpp-generation to built-in plugins list

* fix: correct changelog - only sdcpp-generation was added to constants

---------

Co-authored-by: Proletter <40578159+Proletter@users.noreply.github.com>
Co-authored-by: Dmytro Medvinskyi <functionsilence@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants