Skip to content

(internal) llamacpp-llm: tests improved#1121

Closed
mialso wants to merge 5 commits into
mainfrom
internal/llamacpp-llm-dynamic-tools-tests-improved
Closed

(internal) llamacpp-llm: tests improved#1121
mialso wants to merge 5 commits into
mainfrom
internal/llamacpp-llm-dynamic-tools-tests-improved

Conversation

@mialso

@mialso mialso commented Mar 24, 2026

Copy link
Copy Markdown
Contributor

asana task

Description

improve tests, as per comment

  • test_chat_template_utils.cpp: cover the isQwen3Model branch logic that was previously untested

@mialso mialso mentioned this pull request Mar 24, 2026
Closed
1 task
@mialso mialso changed the title (internal) llamacpp-llm: chat template tests with Qwen3 model (internal) llamacpp-llm: tests improved Mar 24, 2026
@mialso

mialso commented Apr 13, 2026

Copy link
Copy Markdown
Contributor Author

moved to mialso#1

@mialso mialso closed this Apr 13, 2026
@github-actions

github-actions Bot commented Apr 13, 2026

Copy link
Copy Markdown
Contributor

Tier-based Approval Status

**PR Tier:** TIER1

**Current Status:** ❌ PENDING

**Requirements:**
- 1 Team Member approval ❌ (0/1)
- 1 Team Lead OR Management approval ❌ (0/1)



---
*This comment is automatically updated when reviews change.*

@mialso mialso deleted the internal/llamacpp-llm-dynamic-tools-tests-improved branch April 15, 2026 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mialso