Skip to content

fix[notask]: remove filesystem paths from C++ error messages in TTS FileUtils#1105

Merged
sharmaraju352 merged 3 commits into
mainfrom
fix/tts-sanitize-cpp-error-paths
Mar 24, 2026
Merged

fix[notask]: remove filesystem paths from C++ error messages in TTS FileUtils#1105
sharmaraju352 merged 3 commits into
mainfrom
fix/tts-sanitize-cpp-error-paths

Conversation

@sharmaraju352

@sharmaraju352 sharmaraju352 commented Mar 24, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Remove full filesystem paths from std::runtime_error messages in FileUtils.hpp::loadFileBytes() to prevent path leakage when errors propagate to API responses

How was it tested?

  • Unit tests (before & after): 21/21 pass, 63/63 assertions
  • Header-only change — CI prebuild pipeline will validate the C++ compilation

Made with Cursor

fix[notask]: remove filesystem paths from C++ error messages in TTS F…
8d349db 
…ileUtils

The loadFileBytes() helper included the full filesystem path in thrown
runtime_error messages. When these propagate to JS error responses they
leak internal server directory layout. Use generic error messages instead.

Made-with: Cursor
@sharmaraju352 sharmaraju352 requested review from a team as code owners March 24, 2026 07:41
@github-actions

github-actions Bot commented Mar 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Tier-based Approval Status

**PR Tier:** TIER1

**Current Status:** ✅ APPROVED

**Requirements:**
- 1 Team Member approval ✅ (1/1)
- 1 Team Lead OR Management approval ✅ (1/1)



---
*This comment is automatically updated when reviews change.*

@sharmaraju352

sharmaraju352 commented Mar 24, 2026

Copy link
Copy Markdown
Contributor Author

/review

@sharmaraju352

sharmaraju352 commented Mar 24, 2026

Copy link
Copy Markdown
Contributor Author

/review

@sharmaraju352 sharmaraju352 merged commit dac7773 into main Mar 24, 2026
16 of 17 checks passed
@sharmaraju352 sharmaraju352 deleted the fix/tts-sanitize-cpp-error-paths branch March 24, 2026 13:37
@sharmaraju352 sharmaraju352 mentioned this pull request Mar 25, 2026
Merged
Proletter pushed a commit that referenced this pull request May 24, 2026
@sharmaraju352
fix[notask]: remove filesystem paths from C++ error messages in TTS F…
98a94a8 
…ileUtils (#1105)

The loadFileBytes() helper included the full filesystem path in thrown
runtime_error messages. When these propagate to JS error responses they
leak internal server directory layout. Use generic error messages instead.

Made-with: Cursor

Co-authored-by: Raju <raju.sharma>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ishanvohra2 ishanvohra2 ishanvohra2 approved these changes

@GustavoA1604 GustavoA1604 GustavoA1604 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sharmaraju352 @ishanvohra2 @GustavoA1604