Skip to content

fix[notask]: add 1 MB request body size limit to TTS benchmark server#1102

Merged
sharmaraju352 merged 3 commits into
mainfrom
fix/tts-benchmark-body-size-limit
Mar 24, 2026
Merged

fix[notask]: add 1 MB request body size limit to TTS benchmark server#1102
sharmaraju352 merged 3 commits into
mainfrom
fix/tts-benchmark-body-size-limit

Conversation

@sharmaraju352

@sharmaraju352 sharmaraju352 commented Mar 24, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add 1 MB body size limit to TTS benchmark server's processJsonRequest() to prevent DoS via memory exhaustion

How was it tested?

  • Unit tests (before & after): 21/21 pass, 63/63 assertions

Made with Cursor

fix[notask]: add 1 MB request body size limit to TTS benchmark server
b89fd8d 
The TTS benchmark server processJsonRequest() accumulated the entire
request body without any size limit. A single large POST could exhaust
server memory. Add a 1 MB cap consistent with the whisper benchmark
server implementation.

Made-with: Cursor
@sharmaraju352 sharmaraju352 requested review from a team as code owners March 24, 2026 07:38
@github-actions

github-actions Bot commented Mar 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Tier-based Approval Status

**PR Tier:** TIER1

**Current Status:** ✅ APPROVED

**Requirements:**
- 1 Team Member approval ✅ (1/1)
- 1 Team Lead OR Management approval ✅ (1/1)



---
*This comment is automatically updated when reviews change.*

@sharmaraju352

sharmaraju352 commented Mar 24, 2026

Copy link
Copy Markdown
Contributor Author

/review

@sharmaraju352

sharmaraju352 commented Mar 24, 2026

Copy link
Copy Markdown
Contributor Author

/review

@sharmaraju352

sharmaraju352 commented Mar 24, 2026

Copy link
Copy Markdown
Contributor Author

/review

@sharmaraju352 sharmaraju352 merged commit e9d83ca into main Mar 24, 2026
19 of 22 checks passed
@sharmaraju352 sharmaraju352 deleted the fix/tts-benchmark-body-size-limit branch March 24, 2026 13:38
@sharmaraju352 sharmaraju352 mentioned this pull request Mar 25, 2026
Merged
Proletter pushed a commit that referenced this pull request May 24, 2026
@sharmaraju352
fix[notask]: add 1 MB request body size limit to TTS benchmark server (…
da4fba6 
…#1102)

The TTS benchmark server processJsonRequest() accumulated the entire
request body without any size limit. A single large POST could exhaust
server memory. Add a 1 MB cap consistent with the whisper benchmark
server implementation.

Made-with: Cursor

Co-authored-by: Raju <raju.sharma>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ishanvohra2 ishanvohra2 ishanvohra2 approved these changes

@GustavoA1604 GustavoA1604 GustavoA1604 approved these changes

Assignees

No one assigned

Labels

tier1 verify

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sharmaraju352 @ishanvohra2 @GustavoA1604