Skip to content

fix[notask]: resolve code scanning security findings in nmtcpp and ocr-onnx #1060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
olyasir merged 6 commits into from
Mar 20, 2026
Merged

fix[notask]: resolve code scanning security findings in nmtcpp and ocr-onnx #1060

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
dd3d726
fix[notask]: resolve code scanning security findings in nmtcpp and oc…
olyasir Mar 20, 2026
212ea45
fix[notask]: resolve polynomial ReDoS in numeral and other patterns
olyasir Mar 20, 2026
0aa03d4
Merge branch 'main' into fix/security-code-scanning-nmtcpp-ocr
RamazTs Mar 20, 2026
d8de87e
fix[notask]: bound regex quantifiers to eliminate polynomial ReDoS
olyasir Mar 20, 2026
87a481b
Merge branch 'main' into fix/security-code-scanning-nmtcpp-ocr
olyasir Mar 20, 2026
517f5da
Merge branch 'main' into fix/security-code-scanning-nmtcpp-ocr
olyasir Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/ocr-onnx/benchmarks/quality_eval/benchmark_100.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,9 @@ def run_qvac_benchmark(images):
f.write(img + '\n')
input_file = f.name

output_file = tempfile.mktemp(suffix='.jsonl')
output_fd = tempfile.NamedTemporaryFile(mode='w', suffix='.jsonl', delete=False)
output_file = output_fd.name
output_fd.close()

try:
# Run QVAC batch CLI
Expand Down
8 changes: 4 additions & 4 deletions packages/qvac-lib-infer-nmtcpp/third-party/indic-processor-deps/indicnlp/indic_normalize.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -427,7 +427,7 @@ class DevanagariNormalizer extends BaseNormalizer {
}

// replace pipe character for poorna virama
text = text.replace('\u007c', '\u0964')
text = text.replace(/\u007c/g, '\u0964')

// correct visarga
text = text.replace(/([ऀ-ॿ]):/, '$1\u0903')
Expand Down Expand Up @@ -565,7 +565,7 @@ class GurmukhiNormalizer extends BaseNormalizer {
text = text.replace('\u0a65', '\u0965')

// replace pipe character for poorna virama
text = text.replace('\u007c', '\u0964')
text = text.replace(/\u007c/g, '\u0964')

// correct visarga
text = text.replace(/([਀-੿]):/, '$1\u0a03')
Expand Down Expand Up @@ -790,9 +790,9 @@ class BengaliNormalizer extends BaseNormalizer {
text = text.replace('\u09e5', '\u0965')

// replace pipe character for poorna virama
text = text.replace('\u007c', '\u0964')
text = text.replace(/\u007c/g, '\u0964')
// replace bengali currency numerator four for poorna virama (it looks similar and is used as a substitute)
text = text.replace('\u09f7', '\u0964')
text = text.replace(/\u09f7/g, '\u0964')

// two part dependent vowels
text = text.replace('\u09c7\u09be', '\u09cb')
Expand Down
4 changes: 2 additions & 2 deletions packages/qvac-lib-infer-nmtcpp/third-party/indic-processor-deps/sacremoses/tokenizer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,8 +331,8 @@ class MosesTokenizer {

// Protected patterns
this.BASIC_PROTECTED_PATTERN_1 = /<\/?\S+\/?>/
this.BASIC_PROTECTED_PATTERN_2 = /<\S+( [a-zA-Z0-9]+="?[^"]*")+ ?\/?>/
this.BASIC_PROTECTED_PATTERN_3 = /<\S+( [a-zA-Z0-9]+='?[^']*')+ ?\/?>/
this.BASIC_PROTECTED_PATTERN_2 = /<\S+(?: [a-zA-Z0-9]+="[^"]*")+ ?\/?>/
this.BASIC_PROTECTED_PATTERN_3 = /<\S+(?: [a-zA-Z0-9]+='[^']*')+ ?\/?>/
this.BASIC_PROTECTED_PATTERN_4 = /[\w\-_.]+@([\w\-_]+\.)+[a-zA-Z]{2,}/
this.BASIC_PROTECTED_PATTERN_5 =
/(https?|ftp):\/\/[^:/\s]+(\/\w+)*\/[\w\-.]+/
Expand Down
6 changes: 3 additions & 3 deletions packages/qvac-lib-infer-nmtcpp/third-party/indic-processor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,11 +220,11 @@
this._END_BRACKET_SPACE_PUNC_REGEX = /\) ([.!:?;,])/g

this._URL_PATTERN =
/\b(?<![\w/.])(?:(?:https?|ftp):\/\/)?(?:(?:[\w-]+\.)+(?!\.))(?:[\w/\-?#&=%.]+)+(?!\.\w+)\b/g
/\b(?<![\w/.])(?:(?:https?|ftp):\/\/)?(?:[\w-]+\.)+(?!\.)[\w/\-?#&=%.]*(?!\.\w+)\b/g
this._NUMERAL_PATTERN =
/(~?\d+\.?\d*\s?%?\s?-?\s?~?\d+\.?\d*\s?%|~?\d+%|\d+[-/.,:']\d+[-/.,:'+]\d+(?:\.\d+)?|\d+[-/.:'+]\d+(?:\.\d+)?)/g
/(~?\d+(?:\.\d+)?\s?%?\s?-?\s?~?\d+(?:\.\d+)?\s?%|~?\d+%|\d+[-/.,:']\d+[-/.,:']+\d+(?:\.\d+)?|\d+[-/.:'+]\d+(?:\.\d+)?)/g
this._EMAIL_PATTERN = /[A-Za-z0-9._%+-]+@[A-Za-z0-9.-]+\.[A-Z|a-z]{2,}/g
this._OTHER_PATTERN = /[A-Za-z0-9]*[#|@]\w+/g
this._OTHER_PATTERN = /[A-Za-z0-9]{0,100}[#|@]\w+/g

// Combined punctuation replacements
this._PUNC_REPLACEMENTS = [
Expand Down Expand Up @@ -322,7 +322,7 @@
// Find all matches of this pattern
const matches = new Set()
let match
while ((match = pattern.exec(text)) !== null) {

Check failure

Code scanning / CodeQL

Polynomial regular expression used on uncontrolled data High library

This
regular expression
Loading
that depends on
library input
Loading
may run slow on strings with many repetitions of '%'.
This
regular expression
Loading
that depends on
library input
Loading
may run slow on strings with many repetitions of '%'.
matches.add(match[0])
}

Expand Down
Loading