QVAC-14243 doc[skiplog]: migrate for production#1057
Merged
Conversation
* fix: fix race condition in LLM example download utility The redirect handler in examples/utils.js called fs.unlink fire-and-forget then immediately recursed into downloadModel. The recursive call could find the empty file still on disk (existsSync → true) before unlink completed, causing an ENOENT crash on the subsequent statSync. Port the proven download pattern from test/integration/utils.js: - Wait for unlink callback before recursing on redirect - Handle 307/308 redirects (HuggingFace uses 302) - Handle relative redirect URLs - Use safeResolve/safeReject guards to prevent double settlement - Add response error handler and fileStream error handler * fix: use URL constructor for safer redirect resolution * fix: fix race condition in embed and diffusion download utilities Port the proven download pattern from the LLM package (PR #1019): - Wait for fs.unlink callback before recursing on redirect - Add safeResolve/safeReject guards to prevent double settlement - Handle 307/308 redirects in embed examples/utils.js - Add fileStream and response error handlers - Use URL constructor for safer redirect resolution - Use close event instead of finish for write completion --------- Co-authored-by: gianni-cor <gianfranco.cordella@tether.io>
…s - key features - add openAI-compatible API (#1033)
…oved randomly created (#1051) * doc: generate API docs for v0.8.0 * chore[notask]: remove accidentally committed file * fix: fix docs build and escape MDX curly braces in errors.mdx and removed random * fix: revert pre-build script --------- Co-authored-by: Bruno Campana <7632562+BrunoCampana@users.noreply.github.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
Tier-based Approval Status |
Proletter
pushed a commit
that referenced
this pull request
May 24, 2026
* fix: fix race condition in LLM example download utility (#1019) * fix: fix race condition in LLM example download utility The redirect handler in examples/utils.js called fs.unlink fire-and-forget then immediately recursed into downloadModel. The recursive call could find the empty file still on disk (existsSync → true) before unlink completed, causing an ENOENT crash on the subsequent statSync. Port the proven download pattern from test/integration/utils.js: - Wait for unlink callback before recursing on redirect - Handle 307/308 redirects (HuggingFace uses 302) - Handle relative redirect URLs - Use safeResolve/safeReject guards to prevent double settlement - Add response error handler and fileStream error handler * fix: use URL constructor for safer redirect resolution * fix: fix race condition in embed and diffusion download utilities Port the proven download pattern from the LLM package (PR #1019): - Wait for fs.unlink callback before recursing on redirect - Add safeResolve/safeReject guards to prevent double settlement - Handle 307/308 redirects in embed examples/utils.js - Add fileStream and response error handlers - Use URL constructor for safer redirect resolution - Use close event instead of finish for write completion --------- Co-authored-by: gianni-cor <gianfranco.cordella@tether.io> * doc: update README - table of packages - add diffusion and diagnostics - key features - add openAI-compatible API (#1033) * fix: fix docs build and escape MDX curly braces in errors.mdx and removed randomly created (#1051) * doc: generate API docs for v0.8.0 * chore[notask]: remove accidentally committed file * fix: fix docs build and escape MDX curly braces in errors.mdx and removed random * fix: revert pre-build script --------- Co-authored-by: Bruno Campana <7632562+BrunoCampana@users.noreply.github.com> --------- Co-authored-by: Ridwan Taiwo <donriddo@gmail.com> Co-authored-by: gianni-cor <gianfranco.cordella@tether.io> Co-authored-by: Giacomo <119889121+GiacomoSorbiWork@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepare prod env for release.