Updated port qvac-lib-inference-addon-cpp to v0.2.0#6
Merged
Conversation
Contributor
Author
|
@ignaciolarranaga @GustavoA1604 @olyasir @Sero1000 @hamlingreen Please review. |
olyasir
approved these changes
Apr 28, 2025
chetasr
approved these changes
Apr 28, 2025
jpgaribotti
pushed a commit
to jpgaribotti/qvac-registry-vcpkg
that referenced
this pull request
May 7, 2026
Bumps ggml port to the merge of tetherto/qvac-ext-ggml#6 (05afdc59), which lands on top of the previous pin (e16bdae2): - bc053644 metal: IM2COL_3D op + PAD left-padding for Wan video (tetherto#5) - 6d2d24bb metal: tighten IM2COL_3D supports_op (src[1]==F32) - b1923e29 metal: extend IM2COL_3D supports_op for nb[0]==sizeof(float) and F16-dst => F16-kernel match - 05afdc59 Merge pull request tetherto#6 from aegioscy Without these the Metal backend aborts mid-Wan inference with `unsupported op 'IM2COL_3D'` and test-backend-ops support advertises invalid IM2COL_3D combos that hit CPU GGML_ASSERTs. Verified end-to-end on darwin-arm64 via the same source tarball already used by diffusion-cpp's local overlay (now redundant after this bump): ggml@2026-01-30#7 builds with no patches, addon links against it, and Wan2.1 1.3B txt2video runs end-to-end on Metal. Co-authored-by: Cursor <cursoragent@cursor.com>
jpgaribotti
pushed a commit
that referenced
this pull request
May 7, 2026
Bumps ggml port to the merge of tetherto/qvac-ext-ggml#6 (05afdc59), which lands on top of the previous pin (e16bdae2): - bc053644 metal: IM2COL_3D op + PAD left-padding for Wan video (#5) - 6d2d24bb metal: tighten IM2COL_3D supports_op (src[1]==F32) - b1923e29 metal: extend IM2COL_3D supports_op for nb[0]==sizeof(float) and F16-dst => F16-kernel match - 05afdc59 Merge pull request #6 from aegioscy Without these the Metal backend aborts mid-Wan inference with `unsupported op 'IM2COL_3D'` and test-backend-ops support advertises invalid IM2COL_3D combos that hit CPU GGML_ASSERTs. Verified end-to-end on darwin-arm64 via the same source tarball already used by diffusion-cpp's local overlay (now redundant after this bump): ggml@2026-01-30#7 builds with no patches, addon links against it, and Wan2.1 1.3B txt2video runs end-to-end on Metal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.