add qvac lint cpp dependency#26
Closed
kartiksain wants to merge 1 commit into
Closed
Conversation
olek-tether
approved these changes
Aug 25, 2025
jpgaribotti
requested changes
Aug 25, 2025
jpgaribotti
left a comment
jpgaribotti
left a comment
Contributor
There was a problem hiding this comment.
It's not possible to "fix" a port like this. You need to create a new version, as versions are immutable once released.
Zbig9000
added a commit
to Zbig9000/qvac-registry-vcpkg
that referenced
this pull request
May 19, 2026
…993) The two patches the port carried in tetherto#2 (0001-ggml-allow-backend-dl-with- static-core, 0002-ggml-android-cpu-variant-dlopen-fallback) are now upstream-equivalent commits on the whisper.cpp fork at Zbig9000/qvac-ext-lib-whisper.cpp@QVAC-18993-bundled-ggml-android- dynamic-backend (PR tetherto#26 on tetherto/qvac-ext-lib-whisper.cpp). The port can therefore stop maintaining a patch tree. REF flips 47784b9e -> 14620c88 (the QVAC-18993 branch HEAD, which is QVAC-18991's HEAD plus 3 commits: ggml CMakeLists allow-DL-with-static + ggml-backend Android per-arch CPU fallback + tts-cpp chatterbox <atomic> include fix). SHA512 recomputed from the GitHub tarball. Bumps port-version 2 -> 3. The build output is bit-identical to tetherto#2's patched build (verified by running the same NDK r29 cross-compile recipe: all 7 per-arch libggml-cpu-android_armv*_*.so files match byte-for-byte) so this is a pure refactor — patches in vendor-tree vs commits on the upstreamable fork. Drops the whole ports/whisper-cpp/patches/ directory. After whisper-cpp PR tetherto#26 + PR tetherto#25 (QVAC-18991) land on tetherto/master + a v1.8.4.3 tag is published, the port's REF can flip Zbig9000 -> tetherto and v1.8.4.3 (no other changes needed). Co-authored-by: Cursor <cursoragent@cursor.com>
Zbig9000
added a commit
to Zbig9000/qvac-registry-vcpkg
that referenced
this pull request
May 20, 2026
…993) The two patches the port carried in tetherto#2 (0001-ggml-allow-backend-dl-with- static-core, 0002-ggml-android-cpu-variant-dlopen-fallback) are now upstream-equivalent commits on the whisper.cpp fork at Zbig9000/qvac-ext-lib-whisper.cpp@QVAC-18993-bundled-ggml-android- dynamic-backend (PR tetherto#26 on tetherto/qvac-ext-lib-whisper.cpp). The port can therefore stop maintaining a patch tree. REF flips 47784b9e -> 14620c88 (the QVAC-18993 branch HEAD, which is QVAC-18991's HEAD plus 3 commits: ggml CMakeLists allow-DL-with-static + ggml-backend Android per-arch CPU fallback + tts-cpp chatterbox <atomic> include fix). SHA512 recomputed from the GitHub tarball. Bumps port-version 2 -> 3. The build output is bit-identical to tetherto#2's patched build (verified by running the same NDK r29 cross-compile recipe: all 7 per-arch libggml-cpu-android_armv*_*.so files match byte-for-byte) so this is a pure refactor — patches in vendor-tree vs commits on the upstreamable fork. Drops the whole ports/whisper-cpp/patches/ directory. After whisper-cpp PR tetherto#26 + PR tetherto#25 (QVAC-18991) land on tetherto/master + a v1.8.4.3 tag is published, the port's REF can flip Zbig9000 -> tetherto and v1.8.4.3 (no other changes needed). Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Lint Dependency to resolve builds