Skip to content

fix(onnxruntime): correct patch context for v1.24.2 (port-version 5) #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jpgaribotti merged 1 commit into from
Apr 24, 2026
Merged

fix(onnxruntime): correct patch context for v1.24.2 (port-version 5) #129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions ports/onnxruntime/18-fix-coreml-external-data-path.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,12 @@
diff --git a/onnxruntime/core/framework/tensorprotoutils.cc b/onnxruntime/core/framework/tensorprotoutils.cc
index e36be3f..6336e3 100644
--- a/onnxruntime/core/framework/tensorprotoutils.cc
+++ b/onnxruntime/core/framework/tensorprotoutils.cc
@@ -359,7 +359,9 @@ Status TensorProtoWithExternalDataToTensorProto(
@@ -318,7 +318,7 @@
} else {
// Load the external data into memory
std::vector<uint8_t> unpacked_data;
- ORT_RETURN_IF_ERROR(ReadExternalDataForTensor(ten_proto, model_path, unpacked_data));
+ // ReadExternalDataForTensor expects a directory, not a file path.
+ // Fix: use parent_path() to match UnpackInitializerData(). See microsoft/onnxruntime#28005.
+ ORT_RETURN_IF_ERROR(ReadExternalDataForTensor(ten_proto, model_path.parent_path(), unpacked_data));

// Set the raw data in the new tensor
onnxruntime::utils::SetRawDataInTensorProto(result, unpacked_data.data(), unpacked_data.size());
result.set_raw_data(unpacked_data.data(), unpacked_data.size());
2 changes: 1 addition & 1 deletion ports/onnxruntime/vcpkg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"$schema": "https://raw.githubusercontent.com/microsoft/vcpkg-tool/main/docs/vcpkg.schema.json",
"name": "onnxruntime",
"version": "1.24.2",
"port-version": 4,
"port-version": 5,
"description": "ONNX Runtime: cross-platform, high performance ML inferencing and training accelerator",
"homepage": "https://onnxruntime.ai/",
"license": "MIT",
Expand Down
2 changes: 1 addition & 1 deletion versions/baseline.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
},
"onnxruntime": {
"baseline": "1.24.2",
"port-version": 4
"port-version": 5
},
"opencl": {
"baseline": "2024.10.24",
Expand Down
5 changes: 5 additions & 0 deletions versions/o-/onnxruntime.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
{
"versions": [
{
"git-tree": "860cf68ca8928c8f6500008c0606cd9bfd1ada9e",
"version": "1.24.2",
"port-version": 5
},
{
"git-tree": "e33569d0c4b4b745e3bd4d5b681ec2f0220fb56b",
"version": "1.24.2",
Expand Down