onnxruntime: patch CoreML EP external data path bug (port-version 4)#126
Merged
Conversation
GustavoA1604
approved these changes
Apr 21, 2026
jpgaribotti
approved these changes
Apr 21, 2026
jpgaribotti
pushed a commit
that referenced
this pull request
Apr 23, 2026
The CoreML external-data patch (#126) bumped onnxruntime to port-version 4 in versions/o-/onnxruntime.json but missed updating versions/baseline.json. Consumers using the baseline without an explicit override still resolve to port-version 3. Co-authored-by: Mariusz Reichert <reichert.programming@gmail.com>
jpgaribotti
pushed a commit
to jpgaribotti/qvac-registry-vcpkg
that referenced
this pull request
Apr 24, 2026
The patch in tetherto#126 was generated against the upstream main branch where the surrounding code uses SetRawDataInTensorProto(). In v1.24.2 the actual code uses result.set_raw_data(). Fix the context lines and line numbers so the patch applies cleanly. Made-with: Cursor
jpgaribotti
pushed a commit
that referenced
this pull request
Apr 24, 2026
…129) The patch in #126 was generated against the upstream main branch where the surrounding code uses SetRawDataInTensorProto(). In v1.24.2 the actual code uses result.set_raw_data(). Fix the context lines and line numbers so the patch applies cleanly. Co-authored-by: Mariusz Reichert <reichert.programming@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
📝 How does it solve it?
🧪 How was it tested?
will be tested in downstream addons