[TOS-992 / 989] fix: Do not Allow deletion of uploads when used in Test Plans and add Test Plan Name to popup. #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }, | ||
| error=>{console.log(error)} | ||
| ) | ||
| } |
There was a problem hiding this comment.
@Raksha-testsigma Just correct the indentation of the brackets
| } | ||
| } | ||
| } | ||
| private openLinkedTestCasesDialog(list) { |
There was a problem hiding this comment.
@Raksha-testsigma Needs a little formatting. In some cases, there is no line gap between two functions. In some other cases, there are quite a few. Use uniform line gaps
| <div | ||
| *cdkVirtualFor="let linkedEntity of modalData.linkedEntityList ; let index=index; let first=first" | ||
| [class.border-separator-t-1]="first" | ||
| class="list-view md-pm green-highlight"> | ||
| <div (click)="openLinkedEntity(linkedEntity.testPlanId)" class="ts-col-100 pointer d-flex" target="_blank"> | ||
| <div class="text-truncate"> | ||
|
|
||
| <div class="text-truncate w-235"> |
There was a problem hiding this comment.
@Raksha-testsigma Same as in previous comment. Why the extra line gap here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Tickets
https://testsigma.atlassian.net/browse/TOS-989
https://testsigma.atlassian.net/browse/TOS-992
Description