This closes #863 Same xmlsuite is added multiple times when tests are run using TestNG.SetXmlSuites method #897

virenv · 2015-11-25T21:55:00Z

No description provided.

… run using TestNG.SetXmlSuites method

juherr · 2015-11-25T22:00:18Z

src/main/java/org/testng/TestNG.java

@@ -269,28 +269,33 @@ public void setXmlPathInJar(String xmlPathInJar) {
  public void initializeSuitesAndJarFile() {
    // The Eclipse plug-in (RemoteTestNG) might have invoked this method already
    // so don't initialize suites twice.
+	System.out.println("ENTER");


Oops, I think this line is not expected ;)

New to Java and git :(, just fixed it up.

:) You can try to squash all your commits into only one with git interactive rebase. It's for advanced git users but it's really useful.

juherr · 2015-11-25T22:04:15Z

src/main/java/org/testng/TestNG.java

+    //to parse the suite files (<suite-file>), if any
+	for (XmlSuite s: m_suites) {
+	   for (String suiteFile : s.getSuiteFiles()) {
+        	Path suitePath = Paths.get(s.getFileName());


Move suitePath and rootPath between the 2 for.

s.getFileName() can return null in surefire plugin suites. By putting it here we will avoid the surefire plugin case and avoid a null check.

s.getFileName() can return null in surefire plugin suites

Are we agree it is a surefire issue? Do you have an example ?

juherr · 2015-11-25T22:26:31Z

src/main/java/org/testng/TestNG.java

+	        		for (XmlSuite cSuite : childSuites){
+	        			Path childSuite = Paths.get(cSuite.getFileName()).normalize();
+	        			Path parentSuite = Paths.get(suiteFile).normalize();
+	        			if(!childSuite.getFileName().equals(parentSuite.getFileName()))


Instead, what do you think to change parse method to XmlSuite parse(String) (which will add children itself into the parent suite)?
And then add an util method like Collection<XmlSuite> getAllSuite(XmlSuite parent) where we need all suite of the graph.
My proposition is a bit more intrusive but sounds better IMO.

Let me take a look at it tomorrow, will update you on this

There are two things here

parse() has a contract which says it will parse the current suite and also any children that it might have. So its perfectly fine for parse method to return this

Its a public method and will be kind of a change that will impact all who have used this way of running tests. Unless we are trying to add an overload of XmlSuite.parse

This was my original thinking to fix the problem. I dont think that we should try to change much if issue can be fixed with a surgical and logical code change.

If you still think that what you have suggested should be done, please explain more to me about your approach may be with some example.

Maybe you are right but nobody is supposed to use the Parser class.
And I still think the parse() contract has no sense and should parse the current suite, its children and add them instead.

BTW, at least, I suggere to add a new method that will parse children only. Currently, even the variable name is wrong: childSuites.
I think it is better to have this logic into Parser instead of TestNG.

It seems to make sense now, Parse should parse the given XmlSuite and if it find any child it should add as the child to that suite.
However, this is only one level of nesting, what about multiple level of nesting? for eg one suite points to another suite which in turn point a one more suite file.
What I think is that it should be recursive in nature and complete tree should be built from the parent suite to all the children to any given depth.

Let me know you thoughts and let me rewrite the logic after that. However, I still think that if Parser class is not meant to be used by everyone then is this much change worth? But as its a public API, I ended up using it anyway. Same is true for other people, they might have used it with the current contract of parse(). Will that not be a breaking change for them?

However, this is only one level of nesting, what about multiple level of nesting?

For sure, we need some recursive here.

I still think that if Parser class is not meant to be used by everyone then is this much change worth?

I'm agree. But we can add a new method, or an util method that will filter the existing one.
I think the parsing logic should be located in the same class.

juherr · 2015-11-25T22:28:14Z

src/test/java/test/sanitycheck/CheckSuiteNamesTest.java

@@ -81,4 +88,26 @@ public void checkXmlSuiteAddition() throws ParserConfigurationException, SAXExce
    tng.setXmlSuites(parser.parseToList());
    tng.initializeSuitesAndJarFile();		
  }
+
+  @Test(description = "Verify that same suite is not added multiple times")
+  public void validateDuplicateSuiteAddition() throws ParserConfigurationException, SAXException, IOException


Could you add a test for #829 too? We should check that it is still possible to add the same child suite many times.

Same child suite will point to same tests, same tests will fail the check in checkTestNames this method. That is the confusion I have. I am seeing the exception about same test name for two tests in one suite. Lets deal with this in a seperate issue. I will open one for this.

Let me pick this up as a part of next issue. I will log one after understanding the problem in details.

juherr · 2015-11-26T21:51:52Z

src/test/java/test/sanitycheck/SuiteListner.java

+import org.testng.ISuiteListener;
+import org.testng.xml.XmlSuite;
+
+public class SuiteListner implements ISuiteListener {


Typo: SuiteListener

juherr · 2015-11-30T13:56:05Z

@virenv I'd like to make a release soon. Do you think we will be able to close this pull-request before?

virenv · 2015-11-30T19:26:56Z

@juherr I am little bussy till the end of this week. I think by the end of this week I should be able to send a PR. Will that be fine, when are you looking for a release?
On a separate note, we can safely say that this fix is correct based on current understanding of parse method. We can take care of the refactoring of code of parse in a the next release. I can fix that as a part of separate issue, we can merge this PR for current release. What do you say?

juherr · 2015-11-30T20:23:32Z

when are you looking for a release?

No date for the moment. We are waiting for another PR too.

We can take care of the refactoring of code of parse in a the next release.

Why not, but in my opinion there are too many open points for the moment.
Don't worry, at least we will add it in the next release.

virenv · 2015-12-06T05:27:16Z

@juherr I want to inform you that I will take some more time to fix this. I got a crazy schedule this week. Will try to push it in another 4-5 days.

juherr · 2015-12-06T06:23:52Z

Ok, don't worry. I will try to work on it too. I feel it won't be an easy fix.

toolsqa and others added 5 commits November 26, 2015 03:08

This closes #863 Same xmlsuite is added multiple times when tests are…

d627682

… run using TestNG.SetXmlSuites method

This closes #863 Same xmlsuite is added multiple times when tests are…

18f523b

… run using TestNG.SetXmlSuites method

Merge branch 'master' of https://github.com/toolsqa/testng

3dd5f5c

Update

5e010aa

Update TestNG.java

cc5b523

juherr reviewed Nov 25, 2015
View reviewed changes

Build faliure fix

d3712b1

juherr reviewed Nov 25, 2015
View reviewed changes

Build issues fixed

105f3bf

juherr reviewed Nov 25, 2015
View reviewed changes

Review comment update

725e888

juherr reviewed Nov 25, 2015
View reviewed changes

toolsqa added 2 commits November 26, 2015 23:57

Fixing build faliure

33e5c55

adding review comment

183b26e

juherr reviewed Nov 26, 2015
View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

This closes #863 Same xmlsuite is added multiple times when tests are run using TestNG.SetXmlSuites method #897

This closes #863 Same xmlsuite is added multiple times when tests are run using TestNG.SetXmlSuites method #897

virenv commented Nov 25, 2015

juherr Nov 25, 2015

virenv Nov 25, 2015

juherr Nov 25, 2015

juherr Nov 25, 2015

virenv Nov 26, 2015

juherr Nov 26, 2015

juherr Nov 25, 2015

virenv Nov 25, 2015

virenv Nov 26, 2015

juherr Nov 26, 2015

virenv Nov 28, 2015

juherr Nov 28, 2015

juherr Nov 25, 2015

virenv Nov 25, 2015

virenv Nov 26, 2015

juherr Nov 26, 2015

juherr commented Nov 30, 2015

virenv commented Nov 30, 2015

juherr commented Nov 30, 2015

virenv commented Dec 6, 2015

juherr commented Dec 6, 2015

This closes #863 Same xmlsuite is added multiple times when tests are run using TestNG.SetXmlSuites method #897

Are you sure you want to change the base?

This closes #863 Same xmlsuite is added multiple times when tests are run using TestNG.SetXmlSuites method #897

Conversation

virenv commented Nov 25, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

juherr commented Nov 30, 2015

virenv commented Nov 30, 2015

juherr commented Nov 30, 2015

virenv commented Dec 6, 2015

juherr commented Dec 6, 2015