Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Not Equals method for comparing float and dobule arrays - Fixes #1957 #1961

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

atulagrawal
Copy link
Contributor

@atulagrawal atulagrawal commented Nov 25, 2018

Fixes #1957

Closes #1957 .

Did you remember to?

  • Add test case(s)
  • Update CHANGES.txt

We encourage pull requests that:

  • Add new features to TestNG (or)
  • Fix bugs in TestNG

If your pull request involves fixing SonarQube issues then we would suggest that you please discuss this with the
TestNG-dev before you spend time working on it.

@atulagrawal atulagrawal changed the title Added Not Equals method for comparing float and dobule arrays - Fixes 1957 Added Not Equals method for comparing float and dobule arrays - Fixes #1957 Nov 25, 2018
@krmahadevan
Copy link
Member

@atulagrawal - Thanks for the PR. Can you please help do the following

  1. Add unit tests for the changes.
  2. Check the build failure. I noticed that travis build fails for both JDK8 and JDK9

Copy link
Member

@juherr juherr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tests are missing and the build is failing.

}

public static void assertNotEquals(float[] actual, float[] expected, float delta) {
assertNotEquals(actual, expected, delta,"");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: a space is missing after ','

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing assertions assertNotEquals(float[], float[], delta) and assertNotEquals(double[], double[], delta)
3 participants