ConcurrentModificationException #1168

ben-manes · 2016-09-23T22:47:56Z

When running a test class using 6.9.13.8 the tests pass, but the following error is printed. This does not occur in 6.9.12. (Running via Eclipse)

[TestNG] Reporter org.testng.reporters.JUnitReportReporter@2b552920 failed
java.util.ConcurrentModificationException
    at java.util.ArrayList$Itr.checkForComodification(ArrayList.java:901)
    at java.util.ArrayList$Itr.next(ArrayList.java:851)
    at org.testng.reporters.JUnitReportReporter.getNextConfiguration(JUnitReportReporter.java:220)
    at org.testng.reporters.JUnitReportReporter.generateReport(JUnitReportReporter.java:105)
    at org.testng.TestNG.generateReports(TestNG.java:1175)
    at org.testng.TestNG.run(TestNG.java:1102)
    at org.testng.remote.AbstractRemoteTestNG.run(AbstractRemoteTestNG.java:126)
    at org.testng.remote.RemoteTestNG.initAndRun(RemoteTestNG.java:152)
    at org.testng.remote.RemoteTestNG.main(RemoteTestNG.java:57)

The text was updated successfully, but these errors were encountered:

ben-manes · 2016-09-23T22:51:05Z

The problem is that the removeAll is accidentally within the loop body.

for (ITestResult r : confResults) {
  if (! seen.containsKey(r.getMethod())) {
    result += r.getEndMillis() - r.getStartMillis();
    seen.put(r.getMethod(), r);
  }
  confResults.removeAll(seen.values());
}

cbeust · 2016-09-23T22:55:32Z

Good catch. Would you be willing to send a PR?

Cédric

On Fri, Sep 23, 2016 at 3:51 PM, Ben Manes [email protected] wrote:

The problem is that the removeAll is accidentally within the loop body.

for (ITestResult r : confResults) {
if (! seen.containsKey(r.getMethod())) {
result += r.getEndMillis() - r.getStartMillis();
seen.put(r.getMethod(), r);
}
confResults.removeAll(seen.values());
}

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#1168 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAFoogjcy_B02Xw2Ctev-UfjVm-cQ8K0ks5qtFfZgaJpZM4KFdZo
.

ConcurrentModificationException during iteration (fixes #1168)

shabana-parveen · 2016-10-04T10:17:22Z

when will we expect the issue fixed release? as I am also getting the same issue.

missedone · 2016-10-05T00:51:07Z

hi @shabana-parveen
the fix is available in 6.9.13.8 on jCenter.

shabana-parveen · 2016-10-05T04:28:08Z

Thanks @missedone

azell · 2016-10-11T02:51:59Z

Still seeing the error with 6.9.13.8 and u102:

Running TestSuite
[TestNG] Reporter org.testng.reporters.JUnitReportReporter@6e4de19b failed
java.util.ConcurrentModificationException
    at java.util.ArrayList$Itr.checkForComodification(ArrayList.java:901)
    at java.util.ArrayList$Itr.next(ArrayList.java:851)
    at org.testng.reporters.JUnitReportReporter.getNextConfiguration(JUnitReportReporter.java:220)
    at org.testng.reporters.JUnitReportReporter.generateReport(JUnitReportReporter.java:105)
    at org.testng.TestNG.generateReports(TestNG.java:1175)
    at org.testng.TestNG.run(TestNG.java:1102)
    at org.apache.maven.surefire.testng.TestNGExecutor.run(TestNGExecutor.java:132)
    at org.apache.maven.surefire.testng.TestNGDirectoryTestSuite.executeMulti(TestNGDirectoryTestSuite.java:193)
    at org.apache.maven.surefire.testng.TestNGDirectoryTestSuite.execute(TestNGDirectoryTestSuite.java:94)
    at org.apache.maven.surefire.testng.TestNGProvider.invoke(TestNGProvider.java:147)
    at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:290)
    at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:242)
    at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:121)

POM:

      <dependency>
        <groupId>org.testng</groupId>
        <artifactId>testng</artifactId>
        <version>6.9.13.8</version>
      </dependency>

ben-manes · 2016-10-11T03:01:05Z

I don't see my fix in 6.9.13.8 (viewed from source jar). So while .8 was released that day, its probably from an earlier commit.

gdemecki · 2016-10-21T11:02:25Z

Exactly. This issue is still present in the version 6.9.13.8.

shabana-parveen · 2016-10-21T11:32:51Z

Yes, I can also see the same

jeffnyman · 2016-10-24T12:58:17Z

This issue appears to be closed but I, like others, are still seeing the issue. Just making sure that folks area aware this is still a problem, including with the 6.9.13.8 release.

juherr · 2016-10-24T18:28:50Z

The fix should be available in the next release.

Downgrade testng, because of: testng-team/testng#1168.

)

randy-li · 2016-11-25T00:26:23Z

When shall we release next version. See the problem on 6.9.13.8 with Eclipse. Thanks!

kodayashi · 2016-11-29T23:17:05Z

Hi there. Any ETA on a release vehicle that contains this fix? I'm stuck on this release due to a fix that I need in 6.9.13.x :)

krmahadevan · 2016-11-30T02:52:32Z

@kodayashi - The latest version of TestNG viz., 6.10 is already available in bintray.

You can just add the following and you should be able to consume it

<repositories>
    <repository>
        <id>bintray-cbeust-maven</id>
        <name>bintray</name>
        <url>http://dl.bintray.com/cbeust/maven</url>
    </repository>
</repositories>
<dependencies>
    <dependency>
        <groupId>org.testng</groupId>
        <artifactId>testng</artifactId>
        <version>6.10</version>
    </dependency>
</dependencies>

forresthopkinsa · 2016-11-30T02:59:07Z

Is 6.10 stable? Production ready?

krmahadevan · 2016-11-30T03:00:00Z

Not sure what you mean by "Production ready" ? A released product is meant to be stable consumable no ?

forresthopkinsa · 2016-11-30T03:02:54Z

I'm asking if this is a Beta you're suggesting

krmahadevan · 2016-11-30T03:04:27Z

No this is not a beta. This is a released version of TestNG.

forresthopkinsa · 2016-11-30T03:05:36Z

Cool, thanks. Is there a timeline for when it will be in Eclipse's repositories?

krmahadevan · 2016-11-30T03:08:28Z

@cbeust should be able to answer that. I know he mentioned he is going to be pushing the changes to Maven Central as well.

forresthopkinsa · 2016-12-02T01:19:31Z

Lol, so is it a Beta after all? Someone enlighten me

missedone · 2016-12-02T01:21:26Z

TestNG 6.10 is released.
TestNG Eclipse Plugin 6.10.x is still in beta, will be released in any seconds.

kodayashi · 2016-12-02T01:31:41Z

Sweet, thanks everyone!

forresthopkinsa · 2016-12-02T01:35:30Z

Neat. Good work folks

…NG to the version 6.10. It seems to be working: the java.util.ConcurrentModificationException when performing 'mvn test' is no more.

missedone · 2016-12-04T13:20:35Z

TestNG Eclipse Plugin 6.10.0.201612030230 is released.

galan · 2016-12-06T13:18:48Z

When will 6.10.x be available from the Maven Central?
http://search.maven.org/#search%7Cga%7C1%7Cg%3A%22org.testng%22%20AND%20a%3A%22testng%22

juherr · 2016-12-06T13:33:16Z

@galan #1261

sbabcoc · 2016-12-10T01:34:47Z

The 6.10.x release that will contain the fix for this issue has still not been posted yet. When can we expect this to be available?

missedone · 2016-12-10T01:39:52Z

@sbabcoc
TestNG 6.10 is available both on Maven Central and jCenter.
TestNG Eclipse Plugin 6.10.0.201612030230 is available on the release update site

sbabcoc · 2016-12-10T19:14:28Z

I upgraded to TestNG 6.10.0.201612030230, and this issue still exists.

missedone · 2016-12-11T01:16:20Z

@sbabcoc , Eclipse Plugin simply respects the testng jar version of your project, so could you check the testng version on your project classpath? make sure that's up to date.

VESPA-6175

anand853 · 2017-02-09T14:28:11Z

still i hit the same problem with testng 6.10. can you please share the workaround on this?

juherr · 2017-02-09T14:29:39Z

@anand853 Could you share your stacktrace? I bet the issue is not the same but a similar one.

anand853 · 2017-02-09T14:51:11Z

@juherr ,please find the logs

testng.xml configuration:

name="Suite" parallel="methods"

Maven Error logs:
Tests run: 331, Failures: 5, Errors: 0, Skipped: 0, Time elapsed: 1,082.119 sec <<< FAILURE!
test62(test.com.t.test.com.t.AppRoombaHelpTest) Time elapsed: 0.01 sec <<< FAILURE!
java.util.ConcurrentModificationException: null
at java.util.ArrayList$Itr.checkForComodification(ArrayList.java:901)
at java.util.ArrayList$Itr.next(ArrayList.java:851)
at com.relevantcodes.extentreports.model.Test.trackLastRunStatus(Test.java:389)
at com.relevantcodes.extentreports.ExtentTest.log(ExtentTest.java:101)
at com.relevantcodes.extentreports.ExtentTest.log(ExtentTest.java:180)
at test.com.t.sitecores.curlHelpRoomba(sitecores.java:1475)
at test.com.t.test.com.t.AppRoombaHelpTest.test62(AppRoombaHelpTest.java:610)

test73(test.com.t.test.com.t.AppBraavaTermsTest) Time elapsed: 0 sec <<< FAILURE!
java.util.ConcurrentModificationException: null
at java.util.ArrayList$Itr.checkForComodification(ArrayList.java:901)
at java.util.ArrayList$Itr.next(ArrayList.java:851)
at com.relevantcodes.extentreports.model.Test.trackLastRunStatus(Test.java:389)
at com.relevantcodes.extentreports.ExtentTest.log(ExtentTest.java:101)
at com.relevantcodes.extentreports.ExtentTest.log(ExtentTest.java:180)
at test.com.t.test.com.t.AppBraavaTermsTest.test73(AppBraavaTermsTest.java:604)

test77(test.com.t.test.com.t.AppBraavaTermsTest) Time elapsed: 0.169 sec <<< FAILURE!
org.json.JSONException: A JSONObject text must begin with '{' at 1 [character 2 line 1]
at org.json.JSONTokener.syntaxError(JSONTokener.java:451)
at org.json.JSONObject.(JSONObject.java:195)
at org.json.JSONObject.(JSONObject.java:319)
at test.com.t.sitecores.curlBraavaTermsBase(sitecores.java:1222)
at test.com.t.sitecores.curlBraavaTerms(sitecores.java:1187)
at test.com.t.test.com.t.AppBraavaTermsTest.test77(AppBraavaTermsTest.java:632)

test76(test.com.t.test.com.t.AppBraavaTermsTest) Time elapsed: 0.17 sec <<< FAILURE!
java.lang.NullPointerException: null
at com.relevantcodes.extentreports.model.Test.trackLastRunStatus(Test.java:390)
at com.relevantcodes.extentreports.ExtentTest.log(ExtentTest.java:101)
at com.relevantcodes.extentreports.ExtentTest.log(ExtentTest.java:180)
at test.com.t.sitecores.curlBraavaTerms(sitecores.java:1188)
at test.com.t.test.com.t.AppBraavaTermsTest.test76(AppBraavaTermsTest.java:626)

test66(test.com.t.test.com.t.AppBraavaTermsTest) Time elapsed: 0.17 sec <<< FAILURE!
java.lang.NullPointerException: null
at com.relevantcodes.extentreports.model.Test.trackLastRunStatus(Test.java:390)
at com.relevantcodes.extentreports.ExtentTest.log(ExtentTest.java:101)
at com.relevantcodes.extentreports.ExtentTest.log(ExtentTest.java:180)
at test.com.t.sitecores.curlBraavaTerms(sitecores.java:1188)
at test.com.t.test.com.t.AppBraavaTermsTest.test66(AppBraavaTermsTest.java:549)

Results :

Failed tests:
AppRoombaHelpTest.test62:610 » ConcurrentModification
AppBraavaTermsTest.test73:604 » ConcurrentModification
AppBraavaTermsTest.test77:632 » JSON A JSONObject text must begin with '{' at ...
AppBraavaTermsTest.test76:626 » NullPointer
AppBraavaTermsTest.test66:549 » NullPointer

Tests run: 331, Failures: 5, Errors: 0, Skipped: 0

[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 18:04 min
[INFO] Finished at: 2017-02-09T09:45:25-05:00
[INFO] Final Memory: 20M/316M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.14.1:test (default-test) on project com.sitecore.irobot: There are test failures.
[ERROR]

krmahadevan · 2017-02-09T15:01:06Z

@anand853 - This is not a problem from TestNG. Looks like you are facing this problem from extent reports, to be specific this method. I would suggest that you please file a bug here

anand853 · 2017-02-09T15:03:50Z

@krmahadevan ,
can you please provide me any workaround on this?

krmahadevan · 2017-02-09T15:07:27Z

@anand853 - There are no work arounds for this. Extent Reports needs to fix itself so that it doesn't try to modify and iterate a List at the same time without any sort of synchronization mechanism that wraps access to the list. That would ensure that you don't see this exception from extent reports. Not much can be done, apart from fixing the problematic code.

juherr · 2017-02-09T15:17:38Z

For reference: anshooarora/extentreports-java#769

anand853 · 2017-03-10T15:57:07Z

version : 6.10
with the testng also im getting same error, can you please let us know which version of the jar and how to achieve parallel execution with testNG

error
java.util.ConcurrentModificationException
at test.com.t.social.A.es_(A.java:1049)

Results :

Failed tests:
AA.es_:1049 » ConcurrentModification

Tests run: 260, Failures: 1, Errors: 0, Skipped: 0

[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 55:11 min
[INFO] Finished at: 2017-03-10T10:50:25-05:00
[INFO] Final Memory: 22M/370M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test (default-test) on project bot: There are test failures.
[ERROR]
[ERROR] Please refer to svalidation/target/surefire-reports for the individual test results.
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

juherr · 2017-03-10T16:03:51Z

@anand853

java.util.ConcurrentModificationException
at test.com.t.social.A.es_(A.java:1049)

It looks the exception comes from the test itself and not TestNG

tkk-priya · 2020-09-30T11:15:57Z

Hi all,

I am using testng-version 7.1.0, getting concurrentModificationException in following line.
My Code: ExtentManager.getTestStep().log(Status.INFO, m);

Error:
java.util.ConcurrentModificationException
at java.util.ArrayList$Itr.checkForComodification(ArrayList.java:909)
at java.util.ArrayList$Itr.next(ArrayList.java:859)
at com.aventstack.extentreports.ExtentObservable.collectRunInfo(ExtentObservable.java:465)
at com.aventstack.extentreports.ExtentObservable.addLog(ExtentObservable.java:309)
at com.aventstack.extentreports.ExtentTest.addLog(ExtentTest.java:359)
at com.aventstack.extentreports.ExtentTest.log(ExtentTest.java:308)
at com.aventstack.extentreports.ExtentTest.log(ExtentTest.java:333)
at com.aventstack.extentreports.ExtentTest.log(ExtentTest.java:352)

Note: i use DataProvider, Multithreading.

juherr · 2020-09-30T11:45:41Z

@anandhapriyak Your issue comes from com.aventstack.extentreports. You should open an issue there https://github.com/extent-framework/extentreports-java

forresthopkinsa · 2020-09-30T18:01:46Z

Jeez, talk about necro 😅

ben-manes mentioned this issue Sep 23, 2016

ConcurrentModificationException during iteration (fixes #1168) #1169

Merged

cbeust closed this as completed in ee78cc3 Sep 23, 2016

cbeust added a commit that referenced this issue Sep 23, 2016

Merge pull request #1169 from ben-manes/master

ff464f1

ConcurrentModificationException during iteration (fixes #1168)

juherr mentioned this issue Oct 17, 2016

DataProviderTest.shouldNotThrowConcurrentModificationException is failing #1170

Closed

gdemecki mentioned this issue Oct 21, 2016

[Bug] ConcurrentModificationException when generating JUnit report #1212

Closed

7 tasks

marosseleng mentioned this issue Oct 31, 2016

Downgrade testng. marosseleng/Kodemon#24

Merged

marosseleng added a commit to marosseleng/Kodemon that referenced this issue Oct 31, 2016

Merge pull request #24 from mseleng/hotfix/testng-version

ad90bf3

Downgrade testng, because of: testng-team/testng#1168.

bartoszmajsak mentioned this issue Nov 11, 2016

testng 6.9.12+ arquillian/arquillian-core#117

Closed

martoe pushed a commit to martoe/testng that referenced this issue Nov 11, 2016

ConcurrentModificationException during iteration (fixes testng-team#1168

ce354bf

)

gjoranv added a commit to vespa-engine/vespa that referenced this issue Jan 11, 2017

Upgrade testNG to get a fix for testng-team/testng#1168

37c4f00

VESPA-6175

cmcgarel mentioned this issue Jan 11, 2017

Added outstanding unit tests to 'unit-test' group ONSdigital/dp-dd-database-loader#13

Merged

juherr mentioned this issue Feb 12, 2017

Exclude passed test configs from testng-failed.xml #1326

Merged

2 tasks

cheungtitus mentioned this issue Apr 29, 2018

org.testng.reporters.JUnitReportReporter failed kenrui-group/packetbroker#1

Closed

krmahadevan mentioned this issue Oct 1, 2020

ConcurrentModificationException #2373

Closed

vdelendik mentioned this issue Jun 2, 2022

parallel execution of the huge suite (5+ threads) have a lot of skips zebrunner/carina-cucumber#38

Closed

ConcurrentModificationException #1168

ConcurrentModificationException #1168

Comments

ben-manes commented Sep 23, 2016

ben-manes commented Sep 23, 2016

cbeust commented Sep 23, 2016

shabana-parveen commented Oct 4, 2016

missedone commented Oct 5, 2016

shabana-parveen commented Oct 5, 2016

azell commented Oct 11, 2016

ben-manes commented Oct 11, 2016

gdemecki commented Oct 21, 2016

shabana-parveen commented Oct 21, 2016 • edited Loading

jeffnyman commented Oct 24, 2016

juherr commented Oct 24, 2016

randy-li commented Nov 25, 2016

kodayashi commented Nov 29, 2016

krmahadevan commented Nov 30, 2016 • edited Loading

forresthopkinsa commented Nov 30, 2016

krmahadevan commented Nov 30, 2016

forresthopkinsa commented Nov 30, 2016

krmahadevan commented Nov 30, 2016

forresthopkinsa commented Nov 30, 2016

krmahadevan commented Nov 30, 2016

forresthopkinsa commented Dec 2, 2016

missedone commented Dec 2, 2016

kodayashi commented Dec 2, 2016

forresthopkinsa commented Dec 2, 2016

missedone commented Dec 4, 2016

galan commented Dec 6, 2016

juherr commented Dec 6, 2016

sbabcoc commented Dec 10, 2016

missedone commented Dec 10, 2016

sbabcoc commented Dec 10, 2016

missedone commented Dec 11, 2016

anand853 commented Feb 9, 2017

juherr commented Feb 9, 2017

anand853 commented Feb 9, 2017 • edited Loading

krmahadevan commented Feb 9, 2017

anand853 commented Feb 9, 2017

krmahadevan commented Feb 9, 2017

juherr commented Feb 9, 2017

anand853 commented Mar 10, 2017 • edited Loading

juherr commented Mar 10, 2017

tkk-priya commented Sep 30, 2020

juherr commented Sep 30, 2020 • edited Loading

forresthopkinsa commented Sep 30, 2020 • edited Loading

shabana-parveen commented Oct 21, 2016 •

edited

Loading

krmahadevan commented Nov 30, 2016 •

edited

Loading

anand853 commented Feb 9, 2017 •

edited

Loading

anand853 commented Mar 10, 2017 •

edited

Loading

juherr commented Sep 30, 2020 •

edited

Loading

forresthopkinsa commented Sep 30, 2020 •

edited

Loading