test: Fail on unexpected console.warn and console.error#1139
Merged
eps1lon merged 1 commit intotesting-library:mainfrom Dec 6, 2022
Merged
test: Fail on unexpected console.warn and console.error#1139eps1lon merged 1 commit intotesting-library:mainfrom
eps1lon merged 1 commit intotesting-library:mainfrom
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 53f7fdc:
|
Codecov Report
@@ Coverage Diff @@
## main #1139 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 181 181
Branches 36 36
=========================================
Hits 181 181
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
wadah-lendo
approved these changes
Dec 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Fail tests on
console.errorandconsole.warncalls that are not asserted (i.e. some spy intercepts them).Also adds dedicated
toWarnDevandtoErrorDevmatchers (see changed tests).That help surfacing the intended errors better in tests.
Why:
Otherwise we might add tests that include "missign act" warnings which this library is trying to avoid (e.g. in #1137 the added test would all "pass" without any change to the implementation).
How:
Copy (and adjust) the pattern facebook/react uses.
Checklist:
[ ]Documentation added to thedocs site
[ ]TypeScript definitions updated