fix: replace lodash with es-toolkit #671
Closed
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manudeli
force-pushed
the
fix/lodash-to-es-toolkit
branch
from
0b44e2c to
c721767
Compare
4 tasks
|
@gnapse Hello. |
wojtekmaj
approved these changes
Jul 16, 2025
Contributor
wojtekmaj
left a comment
wojtekmaj
left a comment
There was a problem hiding this comment.
LGTM, and it looks like choosing compat function is the right choice here. From what I see, every isEqualWith call is being made with a third argument being compareArraysAsSet util, which might return undefined when we're not comparing two arrays, which would trigger the compat behavior that comes after this line evaluates to false: https://github.com/toss/es-toolkit/blob/main/src/compat/predicate/isEqualWith.ts#L48
Member
|
Superseded by #676 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Replaced usages of lodash utility functions with their equivalents from es-toolkit, and removed lodash from dependencies. Storybook also use es-toolkit
Why:
es-toolkit offers modern, modular alternatives that align with the library's lightweight philosophy.
How:
Identified and replaced individual lodash imports with equivalent functions from es-toolkit/compat.
Adjusted imports accordingly.
Updated unit tests to confirm behavior remains unchanged.
Removed lodash from package.json.
Checklist: