Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme - how to update tsconfig for vitest matchers extension #624

Merged
merged 2 commits into from
Aug 23, 2024

Conversation

mibcadet
Copy link
Contributor

@mibcadet mibcadet commented Aug 21, 2024

What:

Readme was missing info how to update tsconfig for vitest users so extended matchers are not workin in runtime only but also on type checks in devs IDE

Why:

To help devs using typescript and vitest to have typed matchers

How:

After finding solution I edited readme

Checklist:

  • Documentation
  • Tests N/A
  • Updated Type Definitions N/A
  • Ready to be merged

@mibcadet
Copy link
Contributor Author

after long studying and trying to solve my problem with missing types for matchers, I investigated threads here #439 and proposed above update as something that could save me a lot of time.

@lortimer
Copy link

I ran into this today, what lucky timing! This was very helpful to me - I had all the right imports but my IDE (Webstorm) didn't recognize the jest-dom matchers/extended expect until I added the types to my typescript config.

@gnapse gnapse merged commit 8fd402a into testing-library:main Aug 23, 2024
5 checks passed
@gnapse
Copy link
Member

gnapse commented Aug 23, 2024

@all-contributors please add @mibcadet for docs

Copy link
Contributor

@gnapse

I've put up a pull request to add @mibcadet! 🎉

Copy link

🎉 This PR is included in version 6.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants